On 07.12.2013 14:59, Andrey Borzenkov wrote: > В Sat, 07 Dec 2013 14:50:09 +0100 > Vladimir 'φ-coder/phcoder' Serbinenko пишет: > >> On 07.12.2013 11:19, Andrey Borzenkov wrote: >>> grub-install already resolved passed install device to grub device. So do the >>> same as grub-setup and strip parenthesis if we get legacy (hdX). >>> >> Did you test it with both syntaxes? > > Yes. > Go ahead for both parts. Colin told on IRC that he's ok with this patch as well. > linux-cor4:~ # /usr/local/grub2/sbin/grub-install '(hd1)' > FATAL: Error inserting efivars (/lib/modules/3.11.6-4-pae/kernel/drivers/firmware/efi/efivars.ko): No such device > /usr/local/grub2/sbin/grub-install: warning: cannot open directory `/usr/local/grub2/share/locale': No such file or directory. > Installation finished. No error reported. > linux-cor4:~ # /usr/local/grub2/sbin/grub-install /dev/sdb > FATAL: Error inserting efivars (/lib/modules/3.11.6-4-pae/kernel/drivers/firmware/efi/efivars.ko): No such device > /usr/local/grub2/sbin/grub-install: warning: cannot open directory `/usr/local/grub2/share/locale': No such file or directory. > Installation finished. No error reported. > linux-cor4:~ # /usr/local/grub2/sbin/grub-install /dev/disk/by-id/ata-QEMU_HARDDISK_QM00002 > FATAL: Error inserting efivars (/lib/modules/3.11.6-4-pae/kernel/drivers/firmware/efi/efivars.ko): No such device > /usr/local/grub2/sbin/grub-install: warning: cannot open directory `/usr/local/grub2/share/locale': No such file or directory. > Installation finished. No error reported. > linux-cor4:~ # cat /boot/grub/device.map > (hd0) /dev/disk/by-id/ata-QEMU_HARDDISK_QM00001 > (hd1) /dev/disk/by-id/ata-QEMU_HARDDISK_QM00002 > linux-cor4:~ # exit > > > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel >