From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54499)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1VpbF3-0004sh-NW
	for qemu-devel@nongnu.org; Sun, 08 Dec 2013 05:05:43 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1VpbEy-0007TG-13
	for qemu-devel@nongnu.org; Sun, 08 Dec 2013 05:05:37 -0500
Received: from [2a03:4000:1::4e2f:c7ac:d] (port=38360
	helo=v220110690675601.yourvserver.net)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1VpbEx-0007T2-R8
	for qemu-devel@nongnu.org; Sun, 08 Dec 2013 05:05:31 -0500
Message-ID: <52A44465.5040705@weilnetz.de>
Date: Sun, 08 Dec 2013 11:05:25 +0100
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <1386268888-31920-1-git-send-email-sw@weilnetz.de>
	<52A43847.7030001@redhat.com>
In-Reply-To: <52A43847.7030001@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2] libcacard: Fix compilation for older
 versions of glib (bug #1258168)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alon Levy <alevy@redhat.com>, Anthony Liguori <aliguori@amazon.com>
Cc: Laurent Desnogues <laurent.desnogues@gmail.com>, =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= <mlureau@redhat.com>, qemu-devel <qemu-devel@nongnu.org>, Don Slutz <dslutz@verizon.com>

Am 08.12.2013 10:13, schrieb Alon Levy:
> On 12/05/2013 08:41 PM, Stefan Weil wrote:
>> See https://bugs.launchpad.net/bugs/1258168
>>
>> libcacard/vscclient.c: In function 'do_socket_read':
>> libcacard/vscclient.c:410: warning: implicit declaration of function 'g_warn_if_reached'
>> libcacard/vscclient.c:410: warning: nested extern declaration of 'g_warn_if_reached'
>> libcacard/vscclient.c: In function 'main':
>> libcacard/vscclient.c:763: warning: implicit declaration of function 'g_byte_array_unref'
>> libcacard/vscclient.c:763: warning: nested extern declaration of 'g_byte_array_unref'
>> ...
>> libcacard/vscclient.o: In function `do_socket_read':
>> libcacard/vscclient.c:410: undefined reference to `g_warn_if_reached'
>> libcacard/vscclient.o: In function `main':
>> libcacard/vscclient.c:763: undefined reference to `g_byte_array_unref'
>>
>> g_warn_if_reached was added in glib 2.16, and g_byte_array_unref is
>> supported since glib 2.22. QEMU requires glib 2.12, so both names must
>> not be used.
>>
>> Instead of showing a warning for code which should not be reached, QEMU
>> better stops running, so g_warn_if_reached is not useful for QEMU.
> Just note that this fix is in vscclient, so this code is not part of
> qemu executable. If you are using QEMU (all caps) as the whole project,
> the commit message is ok, but it should clarify this is about the
> separate vscclient executable.
>
> Other then that ACK, I can send a pull request with the commit message
> fixed as I suggested.

Thanks for this hint. Please fix the commit message as you suggested.

Regards,
Stefan