From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Amir Vadai <amirv@mellanox.com>, "David S. Miller" <davem@davemloft.net>
Cc: Or Gerlitz <ogerlitz@mellanox.com>,
Yevgeny Petrilin <yevgenyp@mellanox.com>,
netdev@vger.kernel.org, Ido Shamay <idos@mellanox.com>
Subject: Re: [PATCH net-next 07/12] net/mlx4_en: Configure the XPS queue mapping on driver load
Date: Sun, 08 Dec 2013 19:28:30 +0400 [thread overview]
Message-ID: <52A4901E.2030906@cogentembedded.com> (raw)
In-Reply-To: <1386506152-10298-8-git-send-email-amirv@mellanox.com>
Hello.
On 08-12-2013 16:35, Amir Vadai wrote:
> From: Ido Shamay <idos@mellanox.com>
> Only TX rings of User Piority 0 are mapped.
> TX rings of other UP's are using UP 0 mapping.
> XPS is not in use when num_tc is set.
> Signed-off-by: Ido Shamay <idos@mellanox.com>
> Signed-off-by: Amir Vadai <amirv@mellanox.com>
[...]
> diff --git a/drivers/net/ethernet/mellanox/mlx4/mlx4_en.h b/drivers/net/ethernet/mellanox/mlx4/mlx4_en.h
> index fa33a83..a4cdd7d 100644
> --- a/drivers/net/ethernet/mellanox/mlx4/mlx4_en.h
> +++ b/drivers/net/ethernet/mellanox/mlx4/mlx4_en.h
[...]
> @@ -708,8 +710,9 @@ u16 mlx4_en_select_queue(struct net_device *dev, struct sk_buff *skb);
> netdev_tx_t mlx4_en_xmit(struct sk_buff *skb, struct net_device *dev);
>
> int mlx4_en_create_tx_ring(struct mlx4_en_priv *priv,
> - struct mlx4_en_tx_ring **pring,
> - int qpn, u32 size, u16 stride, int node);
> + struct mlx4_en_tx_ring **pring,
> + int qpn, u32 size, u16 stride,
> + int node, int queue_index);
Why you've changed the indentation here -- it was alright before.
> void mlx4_en_destroy_tx_ring(struct mlx4_en_priv *priv,
> struct mlx4_en_tx_ring **pring);
> int mlx4_en_activate_tx_ring(struct mlx4_en_priv *priv,
WBR, Sergei
next prev parent reply other threads:[~2013-12-08 15:28 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-08 12:35 [PATCH net-next 00/12] net/mlx4: Mellanox driver update 08-12-2013 Amir Vadai
2013-12-08 12:35 ` [PATCH net-next 01/12] net/mlx4_en: Reuse mapped memory in RX flow Amir Vadai
2013-12-08 19:20 ` Eric Dumazet
2013-12-09 9:44 ` Amir Vadai
2013-12-09 15:17 ` Eric Dumazet
2013-12-10 9:47 ` Amir Vadai
2013-12-08 12:35 ` [PATCH net-next 02/12] net/mlx4_core: Remove zeroed out of explicit QUERY_FUNC_CAP fields Amir Vadai
2013-12-08 12:35 ` [PATCH net-next 03/12] net/mlx4_core: Rename " Amir Vadai
2013-12-08 12:35 ` [PATCH net-next 04/12] net/mlx4_core: Introduce nic_info new flag in QUERY_FUNC_CAP Amir Vadai
2013-12-08 12:35 ` [PATCH net-next 05/12] net/mlx4_core: Expose physical port id as PF/VF capability Amir Vadai
2013-12-08 12:35 ` [PATCH net-next 06/12] net/mlx4_en: Implement ndo_get_phys_port_id Amir Vadai
2013-12-08 12:35 ` [PATCH net-next 07/12] net/mlx4_en: Configure the XPS queue mapping on driver load Amir Vadai
2013-12-08 15:28 ` Sergei Shtylyov [this message]
2013-12-08 15:42 ` Amir Vadai
2013-12-08 12:35 ` [PATCH net-next 08/12] net/mlx4_core: Set CQE/EQE size to 64B by default Amir Vadai
2013-12-08 12:35 ` [PATCH net-next 09/12] net/mlx4_en: Ignore irrelevant hypervisor events Amir Vadai
2013-12-08 12:35 ` [PATCH net-next 10/12] net/mlx4_en: Add NAPI support for transmit side Amir Vadai
2013-12-08 19:22 ` Eric Dumazet
2013-12-09 10:07 ` Amir Vadai
2013-12-08 12:35 ` [PATCH net-next 11/12] net/mlx4_en: Fix Supported/Advertised link mode reported by ethtool Amir Vadai
2013-12-08 12:35 ` [PATCH net-next 12/12] net/mlx4_core: Check port number for validity before accessing data Amir Vadai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A4901E.2030906@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=amirv@mellanox.com \
--cc=davem@davemloft.net \
--cc=idos@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=yevgenyp@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.