From: Beomho Seo <beomho.seo@samsung.com>
To: linux-iio@vger.kernel.org
Cc: Jonathan Cameron <jic23@kernel.org>
Subject: [PATCH] iio: cm36651: Changed return value of read function
Date: Mon, 09 Dec 2013 11:17:49 +0900 [thread overview]
Message-ID: <52A5284D.4080906@samsung.com> (raw)
Hello,
I have fixed cm36651 driver.
Some return value of callback have been changed to IIO_VAL_INT.
If not IIO_VAL_INT, driver will print wrong value(*_read_int_time) or not print(*_read_prox_thresh).
Signed-off-by: Beomho Seo <beomho.seo@samsung.com>
---
drivers/iio/light/cm36651.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/light/cm36651.c b/drivers/iio/light/cm36651.c
index 21df571..0206eab 100644
--- a/drivers/iio/light/cm36651.c
+++ b/drivers/iio/light/cm36651.c
@@ -387,7 +387,7 @@ static int cm36651_read_int_time(struct cm36651_data *cm36651,
return -EINVAL;
}
- return IIO_VAL_INT_PLUS_MICRO;
+ return IIO_VAL_INT;
}
static int cm36651_write_int_time(struct cm36651_data *cm36651,
@@ -494,7 +494,7 @@ static int cm36651_read_prox_thresh(struct iio_dev *indio_dev,
*val = cm36651->ps_ctrl_regs[CM36651_PS_THD];
- return 0;
+ return IIO_VAL_INT;
}
static int cm36651_write_prox_thresh(struct iio_dev *indio_dev,
--
1.7.9.5
--
Best Regards,
Beomho Seo, Assistant Engineer
System S/W Lab., Software Center, Samsung Electronics
next reply other threads:[~2013-12-09 2:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-09 2:17 Beomho Seo [this message]
2013-12-14 11:17 ` [PATCH] iio: cm36651: Changed return value of read function Jonathan Cameron
2013-12-15 13:04 ` Lars-Peter Clausen
2013-12-15 21:03 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A5284D.4080906@samsung.com \
--to=beomho.seo@samsung.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.