All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: Vlad Yasevich <vyasevich@gmail.com>,
	Zhi Yong Wu <zwu.kernel@gmail.com>,
	davem@davemloft.net
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
Subject: Re: [PATCH 1/2] macvtap: remove useless codes in macvtap_aio_read() and macvtap_recvmsg()
Date: Mon, 09 Dec 2013 11:30:54 +0800	[thread overview]
Message-ID: <52A5396E.8050806@redhat.com> (raw)
In-Reply-To: <52A28A33.4080306@gmail.com>

On 12/07/2013 10:38 AM, Vlad Yasevich wrote:
> On 12/06/2013 03:54 PM, Zhi Yong Wu wrote:
>> > From: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
>> > 
>> > By checking related codes, it is impossible that ret > len or total_len,
>> > so we should remove some useless coeds in both above functions.
> Looks like commit 6680ec68eff47d36f67b4351bc9836fd6cba9532
> Author: Jason Wang <jasowang@redhat.com>
> Date:   Thu Jul 25 13:00:33 2013 +0800
>
>     tuntap: hardware vlan tx support
>
> Introduced a change in tun_put_user() where we can
> never return a length longer then len or total_len.
> This has an effect that is now impossible to signal
> truncated status.  It seems like a potential loss
> of functionality and it might make sense to restore it.
>
> -vlad

True, will send a patch. For macvtap, we'd better also correct current
behaviour to be same with tun.

Thanks

  reply	other threads:[~2013-12-09  3:31 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-06 20:54 [PATCH 1/2] macvtap: remove useless codes in macvtap_aio_read() and macvtap_recvmsg() Zhi Yong Wu
2013-12-06 20:55 ` [PATCH 2/2] tun: remove useless codes in tun_chr_aio_read() and tun_recvmsg() Zhi Yong Wu
2013-12-10  1:36   ` David Miller
2013-12-10 17:18     ` Vlad Yasevich
2013-12-10 19:00       ` David Miller
2013-12-11  3:14         ` Zhi Yong Wu
2013-12-11  3:19           ` David Miller
2013-12-11  3:24             ` Zhi Yong Wu
2013-12-07  2:38 ` [PATCH 1/2] macvtap: remove useless codes in macvtap_aio_read() and macvtap_recvmsg() Vlad Yasevich
2013-12-09  3:30   ` Jason Wang [this message]
2013-12-10  1:36 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52A5396E.8050806@redhat.com \
    --to=jasowang@redhat.com \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=vyasevich@gmail.com \
    --cc=wuzhy@linux.vnet.ibm.com \
    --cc=zwu.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.