From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <52A58633.7060705@ti.com> Date: Mon, 9 Dec 2013 10:58:27 +0200 From: "ivan.khoronzhuk" MIME-Version: 1.0 To: Sekhar Nori Subject: Re: [PATCH v3] ARM: davinci: aemif: get rid of davinci-nand driver dependency on aemif References: <1386267092-18615-1-git-send-email-ivan.khoronzhuk@ti.com> <52A23BE0.2000207@ti.com> In-Reply-To: <52A23BE0.2000207@ti.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, grygorii.strashko@ti.com, linux@arm.linux.org.uk, pawel.moll@arm.com, swarren@wwwdotorg.org, ijc+devicetree@hellion.org.uk, galak@kernel.crashing.org, rob.herring@calxeda.com, linux-kernel@vger.kernel.org, Santosh Shilimkar , rob@landley.net, linux-mtd@lists.infradead.org, computersforpeace@gmail.com, dwmw2@infradead.org, linux-arm-kernel@lists.infradead.org List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 12/06/2013 11:04 PM, Sekhar Nori wrote: > On 12/5/2013 11:41 PM, Ivan Khoronzhuk wrote: > >> diff --git a/arch/arm/mach-davinci/board-mityomapl138.c b/arch/arm/mach-davinci/board-mityomapl138.c >> index 7aa105b..98a66ff 100644 >> --- a/arch/arm/mach-davinci/board-mityomapl138.c >> +++ b/arch/arm/mach-davinci/board-mityomapl138.c >> @@ -432,6 +432,9 @@ static void __init mityomapl138_setup_nand(void) >> { >> platform_add_devices(mityomapl138_devices, >> ARRAY_SIZE(mityomapl138_devices)); >> + >> + if (davinci_aemif_setup(&mityomapl138_nandflash_device)) >> + pr_warn("%s: Cannot configure AEMIF.\n", __func__); >> } > > I must be missing something, but exactly why is this required for > board-mityomapl138.c? > > Thanks, > Sekhar > board-mityomapl138.c - only one board file with NAND_BUSWIDTH_16 option set in pdata. By default bus width is treated as 8 bit, in another case we have to set it. Currently bus width setup is done in davinci_aemif_setup(). So, to set bus width correctly we have to call davinci_aemif_setup() for board in question. -- Regards, Ivan Khoronzhuk From mboxrd@z Thu Jan 1 00:00:00 1970 From: ivan.khoronzhuk@ti.com (ivan.khoronzhuk) Date: Mon, 9 Dec 2013 10:58:27 +0200 Subject: [PATCH v3] ARM: davinci: aemif: get rid of davinci-nand driver dependency on aemif In-Reply-To: <52A23BE0.2000207@ti.com> References: <1386267092-18615-1-git-send-email-ivan.khoronzhuk@ti.com> <52A23BE0.2000207@ti.com> Message-ID: <52A58633.7060705@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 12/06/2013 11:04 PM, Sekhar Nori wrote: > On 12/5/2013 11:41 PM, Ivan Khoronzhuk wrote: > >> diff --git a/arch/arm/mach-davinci/board-mityomapl138.c b/arch/arm/mach-davinci/board-mityomapl138.c >> index 7aa105b..98a66ff 100644 >> --- a/arch/arm/mach-davinci/board-mityomapl138.c >> +++ b/arch/arm/mach-davinci/board-mityomapl138.c >> @@ -432,6 +432,9 @@ static void __init mityomapl138_setup_nand(void) >> { >> platform_add_devices(mityomapl138_devices, >> ARRAY_SIZE(mityomapl138_devices)); >> + >> + if (davinci_aemif_setup(&mityomapl138_nandflash_device)) >> + pr_warn("%s: Cannot configure AEMIF.\n", __func__); >> } > > I must be missing something, but exactly why is this required for > board-mityomapl138.c? > > Thanks, > Sekhar > board-mityomapl138.c - only one board file with NAND_BUSWIDTH_16 option set in pdata. By default bus width is treated as 8 bit, in another case we have to set it. Currently bus width setup is done in davinci_aemif_setup(). So, to set bus width correctly we have to call davinci_aemif_setup() for board in question. -- Regards, Ivan Khoronzhuk From mboxrd@z Thu Jan 1 00:00:00 1970 From: "ivan.khoronzhuk" Subject: Re: [PATCH v3] ARM: davinci: aemif: get rid of davinci-nand driver dependency on aemif Date: Mon, 9 Dec 2013 10:58:27 +0200 Message-ID: <52A58633.7060705@ti.com> References: <1386267092-18615-1-git-send-email-ivan.khoronzhuk@ti.com> <52A23BE0.2000207@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <52A23BE0.2000207@ti.com> Sender: linux-kernel-owner@vger.kernel.org To: Sekhar Nori Cc: Santosh Shilimkar , rob@landley.net, linux@arm.linux.org.uk, mark.rutland@arm.com, devicetree@vger.kernel.org, grygorii.strashko@ti.com, pawel.moll@arm.com, swarren@wwwdotorg.org, ijc+devicetree@hellion.org.uk, galak@kernel.crashing.org, rob.herring@calxeda.com, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, computersforpeace@gmail.com, dwmw2@infradead.org List-Id: devicetree@vger.kernel.org On 12/06/2013 11:04 PM, Sekhar Nori wrote: > On 12/5/2013 11:41 PM, Ivan Khoronzhuk wrote: > >> diff --git a/arch/arm/mach-davinci/board-mityomapl138.c b/arch/arm/mach-davinci/board-mityomapl138.c >> index 7aa105b..98a66ff 100644 >> --- a/arch/arm/mach-davinci/board-mityomapl138.c >> +++ b/arch/arm/mach-davinci/board-mityomapl138.c >> @@ -432,6 +432,9 @@ static void __init mityomapl138_setup_nand(void) >> { >> platform_add_devices(mityomapl138_devices, >> ARRAY_SIZE(mityomapl138_devices)); >> + >> + if (davinci_aemif_setup(&mityomapl138_nandflash_device)) >> + pr_warn("%s: Cannot configure AEMIF.\n", __func__); >> } > > I must be missing something, but exactly why is this required for > board-mityomapl138.c? > > Thanks, > Sekhar > board-mityomapl138.c - only one board file with NAND_BUSWIDTH_16 option set in pdata. By default bus width is treated as 8 bit, in another case we have to set it. Currently bus width setup is done in davinci_aemif_setup(). So, to set bus width correctly we have to call davinci_aemif_setup() for board in question. -- Regards, Ivan Khoronzhuk From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760865Ab3LII75 (ORCPT ); Mon, 9 Dec 2013 03:59:57 -0500 Received: from comal.ext.ti.com ([198.47.26.152]:34424 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754336Ab3LII7z (ORCPT ); Mon, 9 Dec 2013 03:59:55 -0500 Message-ID: <52A58633.7060705@ti.com> Date: Mon, 9 Dec 2013 10:58:27 +0200 From: "ivan.khoronzhuk" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.1 MIME-Version: 1.0 To: Sekhar Nori CC: Santosh Shilimkar , , , , , , , , , , , , , , , Subject: Re: [PATCH v3] ARM: davinci: aemif: get rid of davinci-nand driver dependency on aemif References: <1386267092-18615-1-git-send-email-ivan.khoronzhuk@ti.com> <52A23BE0.2000207@ti.com> In-Reply-To: <52A23BE0.2000207@ti.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.167.145.122] X-EXCLAIMER-MD-CONFIG: f9c360f5-3d1e-4c3c-8703-f45bf52eff6b Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/06/2013 11:04 PM, Sekhar Nori wrote: > On 12/5/2013 11:41 PM, Ivan Khoronzhuk wrote: > >> diff --git a/arch/arm/mach-davinci/board-mityomapl138.c b/arch/arm/mach-davinci/board-mityomapl138.c >> index 7aa105b..98a66ff 100644 >> --- a/arch/arm/mach-davinci/board-mityomapl138.c >> +++ b/arch/arm/mach-davinci/board-mityomapl138.c >> @@ -432,6 +432,9 @@ static void __init mityomapl138_setup_nand(void) >> { >> platform_add_devices(mityomapl138_devices, >> ARRAY_SIZE(mityomapl138_devices)); >> + >> + if (davinci_aemif_setup(&mityomapl138_nandflash_device)) >> + pr_warn("%s: Cannot configure AEMIF.\n", __func__); >> } > > I must be missing something, but exactly why is this required for > board-mityomapl138.c? > > Thanks, > Sekhar > board-mityomapl138.c - only one board file with NAND_BUSWIDTH_16 option set in pdata. By default bus width is treated as 8 bit, in another case we have to set it. Currently bus width setup is done in davinci_aemif_setup(). So, to set bus width correctly we have to call davinci_aemif_setup() for board in question. -- Regards, Ivan Khoronzhuk