From: James Hogan <james.hogan@imgtec.com>
To: Chen Gang <gang.chen.5i5j@gmail.com>
Cc: Seth Jennings <sjenning@linux.vnet.ibm.com>,
linux-mm@kvack.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm/zswap.c: add BUG() for default case in zswap_writeback_entry()
Date: Mon, 9 Dec 2013 10:18:54 +0000 [thread overview]
Message-ID: <52A5990E.2080808@imgtec.com> (raw)
In-Reply-To: <52A5973A.7020509@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 729 bytes --]
On 09/12/13 10:11, Chen Gang wrote:
>> Since the metag compiler is stuck on an old version (gcc 4.2.4), which
>> is wrong to warn in this case, and newer versions of gcc don't appear to
>> warn about it anyway (I just checked with gcc 4.7.2 x86_64), I have no
>> objection to this warning remaining in the metag build.
>>
>
> Do you try "EXTRA_CFLAGS=-W" with gcc 4.7.2? I guess it will report the
> warning too, I don't feel the compiler is smart enough (except it lets
> the long function zswap_get_swap_cache_page really inline) :-)
EXTRA_CFLAGS=-W on gcc 4.7.2 gives me plenty of pointless unused
parameter warnings when compiling mm/zswap.o, but not the warning you're
trying to silence.
Cheers
James
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: James Hogan <james.hogan@imgtec.com>
To: Chen Gang <gang.chen.5i5j@gmail.com>
Cc: Seth Jennings <sjenning@linux.vnet.ibm.com>, <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm/zswap.c: add BUG() for default case in zswap_writeback_entry()
Date: Mon, 9 Dec 2013 10:18:54 +0000 [thread overview]
Message-ID: <52A5990E.2080808@imgtec.com> (raw)
In-Reply-To: <52A5973A.7020509@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 729 bytes --]
On 09/12/13 10:11, Chen Gang wrote:
>> Since the metag compiler is stuck on an old version (gcc 4.2.4), which
>> is wrong to warn in this case, and newer versions of gcc don't appear to
>> warn about it anyway (I just checked with gcc 4.7.2 x86_64), I have no
>> objection to this warning remaining in the metag build.
>>
>
> Do you try "EXTRA_CFLAGS=-W" with gcc 4.7.2? I guess it will report the
> warning too, I don't feel the compiler is smart enough (except it lets
> the long function zswap_get_swap_cache_page really inline) :-)
EXTRA_CFLAGS=-W on gcc 4.7.2 gives me plenty of pointless unused
parameter warnings when compiling mm/zswap.o, but not the warning you're
trying to silence.
Cheers
James
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-12-09 10:19 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-09 2:51 [PATCH] mm/zswap.c: add BUG() for default case in zswap_writeback_entry() Chen Gang
2013-12-09 2:51 ` Chen Gang
2013-12-09 9:54 ` James Hogan
2013-12-09 9:54 ` James Hogan
2013-12-09 10:11 ` Chen Gang
2013-12-09 10:11 ` Chen Gang
2013-12-09 10:18 ` James Hogan [this message]
2013-12-09 10:18 ` James Hogan
2013-12-09 11:21 ` Chen Gang
2013-12-09 11:40 ` James Hogan
2013-12-09 11:40 ` James Hogan
2013-12-09 13:34 ` Chen Gang
2013-12-09 13:34 ` Chen Gang
2013-12-09 15:36 ` Seth Jennings
2013-12-09 15:36 ` Seth Jennings
2013-12-10 2:16 ` Chen Gang
2013-12-10 2:16 ` Chen Gang
2013-12-11 2:11 ` [PATCH v2] " Chen Gang
2013-12-11 2:11 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A5990E.2080808@imgtec.com \
--to=james.hogan@imgtec.com \
--cc=gang.chen.5i5j@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sjenning@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.