Re: GS_USB

[Wolfgang Grandegger <wg@grandegger.com>]

On 12/09/2013 11:52 AM, Marc Kleine-Budde wrote:
> Hello Wolfgang,
> 
> thanks for reviewing the driver.
> 
> On 12/07/2013 11:06 AM, Wolfgang Grandegger wrote:
>>> +static struct gs_can *gs_make_candev(unsigned int channel,
>>>> +	struct usb_interface *intf)
> 
> This function returns a struct gs_can pointer...
> 
>>>> +{
>>>> +	struct gs_can *dev;
>>>> +	struct net_device *netdev;
>>>> +	int rc;
>>>> +	struct gs_device_bt_const *bt_const;
>>>> +
>>>> +	bt_const = kmalloc(sizeof(*bt_const), GFP_KERNEL);
>>>> +	if (!bt_const)
>>>> +		return ERR_PTR(-ENOMEM);
>> This function does not return an error code, therefore just:
>>
>> 		return -ENOMEM;
> 
> ....so ERR_PTR(-ENOMEM) is correct. The error value "-ENOMEM" has to be
> converted to a pointer and this is what ERR_PTR does. The same is true
> for the rest of this function.

Of course. Obviously I got confused as well.

Wolfgang.