From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yh0-f47.google.com (mail-yh0-f47.google.com [209.85.213.47]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 53D66E006C7 for ; Mon, 9 Dec 2013 08:45:50 -0800 (PST) Received: by mail-yh0-f47.google.com with SMTP id 29so2789000yhl.20 for ; Mon, 09 Dec 2013 08:45:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=wp7m8gQHu7y3ZksHWj3o+pfdp7B0+Xf7D2sdp/ue95g=; b=GucMW1fnV/0qDVg500/Edt75G59mhm45IkS08DukeLlb/fCZrxvhBo7zYxYUfZUJp/ Mig9fOKUU/+Lj0NMLKenc65GMc+kG8u2M24wmUPTAE36iJrSP72gv1lpQmGo3VPDijv/ apScLbDWtz5/lOx9mucNNyj2zIKyy/R+QlXnoNnSRJegat7sWKS1hQw8WoWbs5MJAKaX Re6qdgAW0dtc7UeRdKg8HENmi24Cj4UaNci8hDdKDNOCJJHJgSfvlQ/huBPqPahIzF1T vV0/u4xWoxTQ2+J8373ZUc2Bpub8bhrlC8dijvQ6v59/HThFqwd7Y8pfpmNL0v436oGP 5+Zg== X-Received: by 10.236.183.111 with SMTP id p75mr2228139yhm.148.1386607549265; Mon, 09 Dec 2013 08:45:49 -0800 (PST) Received: from goober.local ([75.76.228.60]) by mx.google.com with ESMTPSA id m29sm17095500yho.14.2013.12.09.08.45.46 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 09 Dec 2013 08:45:48 -0800 (PST) Message-ID: <52A5F3BA.3030502@gmail.com> Date: Mon, 09 Dec 2013 10:45:46 -0600 From: John Weber User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:24.0) Gecko/20100101 Thunderbird/24.1.1 MIME-Version: 1.0 To: meta-freescale@yoctoproject.org References: <1386605416-19779-1-git-send-email-rjohnweber@gmail.com> <52A5EF29.3040902@mlbassoc.com> <52A5EFA1.5060806@gmail.com> <52A5F142.70807@mlbassoc.com> In-Reply-To: Subject: Re: [meta-fsl-arm][PATCH] u-boot-fslc: Add tag to git SRC_URI X-BeenThere: meta-freescale@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Usage and development list for the meta-fsl-* layers List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Dec 2013 16:45:50 -0000 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit On 12/9/13 10:35 AM, Otavio Salvador wrote: > Hello Gary, > > On Mon, Dec 9, 2013 at 2:35 PM, Gary Thomas wrote: >> On 2013-12-09 09:28, John Weber wrote: >>> On 12/9/13 10:26 AM, Gary Thomas wrote: >>>> On 2013-12-09 09:10, John Weber wrote: >>>>> From: Dan McGregor >>>>> >>>>> Bitbake now checks for the commit in the master branch by default. >>>>> Explictly set the tag where SRCREV is expected. >>>>> >>>>> Signed-off-by: John Weber >>>>> --- >>>>> recipes-bsp/u-boot/u-boot-fslc_2013.10.bb | 2 +- >>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>> >>>>> diff --git a/recipes-bsp/u-boot/u-boot-fslc_2013.10.bb >>>>> b/recipes-bsp/u-boot/u-boot-fslc_2013.10.bb >>>>> index 73d4371..56c3265 100644 >>>>> --- a/recipes-bsp/u-boot/u-boot-fslc_2013.10.bb >>>>> +++ b/recipes-bsp/u-boot/u-boot-fslc_2013.10.bb >>>>> @@ -11,7 +11,7 @@ PROVIDES += "u-boot" >>>>> PV = "v2013.10" >>>>> >>>>> SRCREV = "079e214888279518ce061c71238a74a0c3db2c28" >>>>> -SRC_URI = "git://github.com/Freescale/u-boot-imx.git" >>>>> +SRC_URI = >>>>> "git://github.com/Freescale/u-boot-imx.git;tag=patches-2013.10" >>>>> >>>>> S = "${WORKDIR}/git" >>>>> >>>>> >>>> >>>> Can you please change this so the branch name can be overridden, as >>>> in the patches I sent for the other recipes? >>>> >>> Hi Gary - I'm not sure if that would be useful since the u-boot recipe >>> does not depend on a .inc file. Where would the override come from? >> >> From .bbappend files in my layers (I have a private BSP layer which >> extend the meta-fsl-arm* layers). > I think what John means is that you'll end rewriting the SRC_URI, no? > > Do you have an use example where you'd need it? > I think he means to do something like this: GITTAG ??= "patches-2013.10" SRC_URI = "git://github.com/Freescale/u-boot-imx.git;tag=${GITTAG}" This way he can override GITTAG in his .bbappend, correct?