From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.chez-thomas.org (mail.mlbassoc.com [65.100.170.105]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 22F1AE006D2 for ; Mon, 9 Dec 2013 08:52:43 -0800 (PST) Received: by mail.chez-thomas.org (Postfix, from userid 1998) id E60BCF81220; Mon, 9 Dec 2013 09:52:42 -0700 (MST) X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on hermes.chez-thomas.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=4.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.3.2 Received: from [192.168.1.114] (zeus [192.168.1.114]) by mail.chez-thomas.org (Postfix) with ESMTP id 9F8F5F8121E; Mon, 9 Dec 2013 09:52:41 -0700 (MST) Message-ID: <52A5F58A.4080301@mlbassoc.com> Date: Mon, 09 Dec 2013 09:53:30 -0700 From: Gary Thomas User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.1 MIME-Version: 1.0 To: meta-freescale@yoctoproject.org References: <1386605416-19779-1-git-send-email-rjohnweber@gmail.com> <52A5EF29.3040902@mlbassoc.com> <52A5EFA1.5060806@gmail.com> <52A5F142.70807@mlbassoc.com> <52A5F3BA.3030502@gmail.com> In-Reply-To: <52A5F3BA.3030502@gmail.com> Subject: Re: [meta-fsl-arm][PATCH] u-boot-fslc: Add tag to git SRC_URI X-BeenThere: meta-freescale@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Usage and development list for the meta-fsl-* layers List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Dec 2013 16:52:44 -0000 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit On 2013-12-09 09:45, John Weber wrote: > > On 12/9/13 10:35 AM, Otavio Salvador wrote: >> Hello Gary, >> >> On Mon, Dec 9, 2013 at 2:35 PM, Gary Thomas wrote: >>> On 2013-12-09 09:28, John Weber wrote: >>>> On 12/9/13 10:26 AM, Gary Thomas wrote: >>>>> On 2013-12-09 09:10, John Weber wrote: >>>>>> From: Dan McGregor >>>>>> >>>>>> Bitbake now checks for the commit in the master branch by default. >>>>>> Explictly set the tag where SRCREV is expected. >>>>>> >>>>>> Signed-off-by: John Weber >>>>>> --- >>>>>> recipes-bsp/u-boot/u-boot-fslc_2013.10.bb | 2 +- >>>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>>> >>>>>> diff --git a/recipes-bsp/u-boot/u-boot-fslc_2013.10.bb >>>>>> b/recipes-bsp/u-boot/u-boot-fslc_2013.10.bb >>>>>> index 73d4371..56c3265 100644 >>>>>> --- a/recipes-bsp/u-boot/u-boot-fslc_2013.10.bb >>>>>> +++ b/recipes-bsp/u-boot/u-boot-fslc_2013.10.bb >>>>>> @@ -11,7 +11,7 @@ PROVIDES += "u-boot" >>>>>> PV = "v2013.10" >>>>>> >>>>>> SRCREV = "079e214888279518ce061c71238a74a0c3db2c28" >>>>>> -SRC_URI = "git://github.com/Freescale/u-boot-imx.git" >>>>>> +SRC_URI = >>>>>> "git://github.com/Freescale/u-boot-imx.git;tag=patches-2013.10" >>>>>> >>>>>> S = "${WORKDIR}/git" >>>>>> >>>>>> >>>>> >>>>> Can you please change this so the branch name can be overridden, as >>>>> in the patches I sent for the other recipes? >>>>> >>>> Hi Gary - I'm not sure if that would be useful since the u-boot recipe >>>> does not depend on a .inc file. Where would the override come from? >>> >>> From .bbappend files in my layers (I have a private BSP layer which >>> extend the meta-fsl-arm* layers). >> I think what John means is that you'll end rewriting the SRC_URI, no? >> >> Do you have an use example where you'd need it? >> > I think he means to do something like this: > > GITTAG ??= "patches-2013.10" > SRC_URI = "git://github.com/Freescale/u-boot-imx.git;tag=${GITTAG}" > > This way he can override GITTAG in his .bbappend, correct? Correct. The ??= isn't even necessary since the .bbappend can always override it. -- ------------------------------------------------------------ Gary Thomas | Consulting for the MLB Associates | Embedded world ------------------------------------------------------------