All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Laszlo Ersek <lersek@redhat.com>
Cc: qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 0/4] i440fx-test: check firmware visibility
Date: Mon, 09 Dec 2013 18:53:20 +0100	[thread overview]
Message-ID: <52A60390.9050600@redhat.com> (raw)
In-Reply-To: <1385745142-20520-1-git-send-email-lersek@redhat.com>

Il 29/11/2013 18:12, Laszlo Ersek ha scritto:
> v3 [Markus]:
> - FW_SIZE -> BLOB_SIZE
> - create_firmware() -> create_blob_file()
> - detach create_blob_file() comment block from firmware & temporariness
> - same in filename and error messages there
> - char unsigned -> uint8_t

Great idea. :)

> 
> Laszlo Ersek (4):
>   i440fx-test: qtest_start() should be paired with qtest_end()
>   i440fx-test: give each GTest case its own qtest
>   i440fx-test: generate temporary firmware blob
>   i440fx-test: verify firmware under 4G and 1M, both -bios and -pflash
> 
>  tests/i440fx-test.c | 167 ++++++++++++++++++++++++++++++++++++++++++++++------
>  1 file changed, 150 insertions(+), 17 deletions(-)
> 

Markus, can you give your Reviewed-by?

Paolo

  parent reply	other threads:[~2013-12-09 17:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-29 17:12 [Qemu-devel] [PATCH v3 0/4] i440fx-test: check firmware visibility Laszlo Ersek
2013-11-29 17:12 ` [Qemu-devel] [PATCH v3 1/4] i440fx-test: qtest_start() should be paired with qtest_end() Laszlo Ersek
2013-11-29 17:12 ` [Qemu-devel] [PATCH v3 2/4] i440fx-test: give each GTest case its own qtest Laszlo Ersek
2013-11-29 17:12 ` [Qemu-devel] [PATCH v3 3/4] i440fx-test: generate temporary firmware blob Laszlo Ersek
2013-11-29 17:12 ` [Qemu-devel] [PATCH v3 4/4] i440fx-test: verify firmware under 4G and 1M, both -bios and -pflash Laszlo Ersek
2013-12-09 17:53 ` Paolo Bonzini [this message]
2013-12-16 16:16 ` [Qemu-devel] [PATCH v3 0/4] i440fx-test: check firmware visibility Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52A60390.9050600@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=armbru@redhat.com \
    --cc=lersek@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.