From: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>
To: David Ahern <dsahern@gmail.com>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf tools: Fix bug for perf kvm report without guestmount.
Date: Mon, 09 Dec 2013 13:44:20 -0500 [thread overview]
Message-ID: <52A60F84.1020106@cn.fujitsu.com> (raw)
In-Reply-To: <52A60ED6.9050903@cn.fujitsu.com>
>> When more than 1 VM, the cases you provided is all about
>> record-report the symbols from __all__ guests. How about I want to
>> record-report one of them?
>> Example:
>> There are 2 guests are running different kernels, I want to
>> record-report VM1.
>>
>> Currently, we can use --guestmount to get the symbols of VM1, but we
>> can not remove the symbols of VM2 from report. It means the
>> percentage of each symbol is not the symbol only in this VM1.
>>
>> What I want with introducing guestpid is to record-report the symbols
>> only from VM1, and ignore VM2.
>>
>
> Besides, as we provide two usages of perf-kvm in manpage,
> guestmount-way and guest{kallsyms,modules}-way, but the
> guest{kallsyms, modules} is not used
s/not/only. Sorry for the typo :(
> when
> there is only one guest is running, the guestmount is used in all
> situations, it seems not reasonable. I think we can provide a guestpid
> to make the guestkallsyms-way can be used in any situation.
>
> This way, user can understand and choose the usage easily.
>
> 1. one or more guests you want to record-report, --guestmount-way. It
> provides the full functionality of perf kvm.
>
> 2. only one guest you want to record-report, --guestmount is also
> available, and there is another usage for this most used case as a
> shortcut , --guest{kallsyms, modules, pid}.
>
> Then the relationship between the two kinds of usage is more clear,
> right? And in this way, we can make the result of perf-kvm more
> foreseeable to user.
>
>>> David
>>>
>>>
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe
>> linux-kernel" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at http://www.tux.org/lkml/
>>
>
> --
> To unsubscribe from this list: send the line "unsubscribe
> linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
prev parent reply other threads:[~2013-12-09 5:46 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-06 21:33 [PATCH] perf tools: Fix bug for perf kvm report without guestmount Dongsheng Yang
2013-12-06 11:56 ` Arnaldo Carvalho de Melo
2013-12-08 17:39 ` David Ahern
2013-12-09 18:07 ` Arnaldo Carvalho de Melo
2013-12-09 18:08 ` David Ahern
2013-12-09 18:49 ` Arnaldo Carvalho de Melo
2013-12-09 19:42 ` David Ahern
2013-12-10 18:54 ` Dongsheng Yang
2013-12-10 6:02 ` David Ahern
2013-12-10 19:07 ` Dongsheng Yang
2013-12-16 16:26 ` [PATCH V2] " Dongsheng Yang
2013-12-16 16:36 ` Dongsheng Yang
2013-12-20 5:31 ` David Ahern
2013-12-20 18:37 ` Dongsheng Yang
2013-12-20 18:41 ` [PATCH V3] " Dongsheng Yang
2013-12-20 5:46 ` David Ahern
2014-01-12 18:36 ` [tip:perf/core] perf kvm: Fix " tip-bot for Dongsheng Yang
2013-12-09 15:20 ` [PATCH] perf tools: Fix bug for perf " Dongsheng Yang
2013-12-09 3:42 ` David Ahern
2013-12-09 17:12 ` Dongsheng Yang
2013-12-09 4:32 ` David Ahern
2013-12-09 18:06 ` Dongsheng Yang
2013-12-09 18:41 ` Dongsheng Yang
2013-12-09 18:44 ` Dongsheng Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A60F84.1020106@cn.fujitsu.com \
--to=yangds.fnst@cn.fujitsu.com \
--cc=acme@ghostprotocols.net \
--cc=dsahern@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.