From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: [PATCH] Arch Linux specific grub-mkconfig fixes
Date: Mon, 09 Dec 2013 20:17:46 +0100 [thread overview]
Message-ID: <52A6175A.3020005@gmail.com> (raw)
In-Reply-To: <CAMPnHXzmETcfrRoot4KqpiqKWzSpYicZuVeC51pZ86WQ2cxwZg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1852 bytes --]
This patch clearly doesn't have right attributions, not split according
to functional changes and some of parts were already discussed. As-is
patch is unacceptable, the biggest problem being the lack of right
attribution. E.g. some parts are apparently by WIP patch by Alexander
Kurtz yet he's never mentioned at all.
Please never ever send patches to GRUB under wrong authorship acknowledges.
On 09.12.2013 20:11, Keshav Padram Amburay wrote:
> Hi,
>
> This patch has been used in Arch Linux's GRUB(2) package for quite some
> time (ever since the release of grub 2.00).
>
> The main feature that distinguishes Arch Linux from other distros is
> that its kernel and initramfs (core/linux pkg) are always installed at
> /boot/vmlinuz-linux and /boot/initramfs-linux.img and this path does not
> contain the actual kernel version info and therefore does not change
> with kernel updates, unlike other distros.
>
> Also Arch Linux includes a secondary (fallback) initramfs image
> at /boot/initramfs-linux-fallback.img which contains modules, that are
> excluded by autodetect hook in the normal initramfs image
> at /boot/initramfs-linux.img . Thus if the user is unable to boot
> using /boot/initramfs-linux.img, he/she may be able to boot
> using /boot/initramfs-linux-fallback.img . Arch Linux and its
> derivatives use this kind of fallback initramfs setup. This patch also
> adds detection of this fallback initramfs image.
>
> I have attached the patch instead of sending this via git-send-mail,
> because 1) I haven't setup git-send-mail, and 2) Mail program seems to
> screw up the line indentation.
>
> With Best Regards,
>
> Keshav
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 291 bytes --]
next prev parent reply other threads:[~2013-12-09 19:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-09 19:11 [PATCH] Arch Linux specific grub-mkconfig fixes Keshav Padram Amburay
2013-12-09 19:17 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
2013-12-09 19:49 ` Keshav Padram Amburay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A6175A.3020005@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.