From: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
To: Florian Fainelli <f.fainelli@gmail.com>, netdev@vger.kernel.org
Cc: davem@davemloft.net, sergei.shtylyov@cogentembedded.com,
afleming@gmail.com, kyle@moffetthome.net
Subject: Re: [PATCH net-next v2 6/9] net: mv643xx_eth: use phy_init_hw to reset PHY
Date: Mon, 09 Dec 2013 21:09:27 +0100 [thread overview]
Message-ID: <52A62377.7050406@gmail.com> (raw)
In-Reply-To: <1386363698-8407-7-git-send-email-f.fainelli@gmail.com>
On 12/06/2013 10:01 PM, Florian Fainelli wrote:
> Instead of open-coding a PHY reset through the MII BMCR register, use
> phy_init_hw() which does that for us and will also make sure that PHY
> fixups are applied if required. We also remove a call to phy_reset()
> due to the following sequence of calls in the driver:
>
> phy_scan()
> -> phy_connect()
> -> phy_connect_direct()
> -> phy_attach_direct()
> -> phy_init_hw()
>
> and we only have a call to phy_init() after phy_scan().
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> Changes since v2:
> - improved commit message and explain why phy_reset() can go away
> entirely
Series tested on mv643xx_eth with Marvell Dove SoC.
Tested-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
> drivers/net/ethernet/marvell/mv643xx_eth.c | 21 +--------------------
> 1 file changed, 1 insertion(+), 20 deletions(-)
next prev parent reply other threads:[~2013-12-09 20:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-06 21:01 [PATCH net-next v2 0/9] net: phy: consolidate PHY reset Florian Fainelli
2013-12-06 21:01 ` [PATCH net-next v2 1/9] net: phy: report link partner features through ethtool Florian Fainelli
2013-12-06 21:01 ` [PATCH net-next v2 2/9] net: phy: use phy_init_hw instead of open-coding it Florian Fainelli
2013-12-06 21:01 ` [PATCH net-next v2 3/9] net: greth: use phy_read_status() Florian Fainelli
2013-12-06 21:01 ` [PATCH net-next v2 4/9] net: bfin_mac: do not reset PHY after phy_start() Florian Fainelli
2013-12-06 21:01 ` [PATCH net-next v2 5/9] net: phy: consolidate PHY reset in phy_init_hw() Florian Fainelli
2013-12-06 21:01 ` [PATCH net-next v2 6/9] net: mv643xx_eth: use phy_init_hw to reset PHY Florian Fainelli
2013-12-09 20:09 ` Sebastian Hesselbarth [this message]
2013-12-06 21:01 ` [PATCH net-next v2 7/9] net: pxa168_eth: use phy_init_hw for PHY reset Florian Fainelli
2013-12-06 21:01 ` [PATCH net-next v2 8/9] net: tc35815: " Florian Fainelli
2013-12-06 21:01 ` [PATCH net-next v2 9/9] net: sh_eth: do not issue a wild PHY reset through BMCR Florian Fainelli
2013-12-10 1:39 ` [PATCH net-next v2 0/9] net: phy: consolidate PHY reset David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A62377.7050406@gmail.com \
--to=sebastian.hesselbarth@gmail.com \
--cc=afleming@gmail.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kyle@moffetthome.net \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.