From: Lars-Peter Clausen <lars@metafoo.de>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>,
Stephen Warren <swarren@nvidia.com>,
Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH 1/5] ASoC: ep93xx: get rid of ep93xx-pcm-audio struct device
Date: Mon, 09 Dec 2013 21:44:51 +0100 [thread overview]
Message-ID: <52A62BC3.1050807@metafoo.de> (raw)
In-Reply-To: <1386620656-18391-2-git-send-email-swarren@wwwdotorg.org>
On 12/09/2013 09:24 PM, Stephen Warren wrote:
[...]
>
> -static int ep93xx_soc_platform_probe(struct platform_device *pdev)
> +int ep93xx_pcm_platform_register(struct device *dev)
> {
> - return snd_dmaengine_pcm_register(&pdev->dev,
> + return snd_dmaengine_pcm_register(dev,
This will have a conflict with the "ASoC: ep93xx: Use
devm_snd_dmaengine_pcm_register()" patch from the topic/ep93xx branch.
Otherwise the patch looks fine to me.
> &ep93xx_dmaengine_pcm_config,
> SND_DMAENGINE_PCM_FLAG_NO_RESIDUE |
> SND_DMAENGINE_PCM_FLAG_NO_DT |
> SND_DMAENGINE_PCM_FLAG_COMPAT);
> }
> +EXPORT_SYMBOL_GPL(ep93xx_pcm_platform_register);
>
next prev parent reply other threads:[~2013-12-09 20:44 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-09 20:24 [PATCH 0/5] ASoC: remove dmaengine compat_request_channel Stephen Warren
2013-12-09 20:24 ` [PATCH 1/5] ASoC: ep93xx: get rid of ep93xx-pcm-audio struct device Stephen Warren
2013-12-09 20:44 ` Lars-Peter Clausen [this message]
2013-12-09 23:50 ` Stephen Warren
2013-12-10 7:47 ` Lars-Peter Clausen
2013-12-10 10:23 ` Mark Brown
2013-12-10 16:56 ` Stephen Warren
2013-12-10 17:02 ` Mark Brown
2013-12-10 11:57 ` Mark Brown
2013-12-10 10:26 ` Mark Brown
2013-12-10 16:58 ` Stephen Warren
2013-12-09 20:24 ` [PATCH 2/5] ASoC: ep93xx: remove custom DMA alloc compat function Stephen Warren
2013-12-10 10:26 ` Mark Brown
2013-12-09 20:24 ` [PATCH 3/5] ASoC: SPEAr: get rid of spear-pcm-audio struct device Stephen Warren
2013-12-09 20:48 ` Lars-Peter Clausen
2013-12-09 20:24 ` [PATCH 4/5] ASoC: SPEAr: remove custom DMA alloc compat function Stephen Warren
2013-12-09 21:17 ` Lars-Peter Clausen
2013-12-10 6:30 ` Rajeev kumar
2013-12-10 7:45 ` Lars-Peter Clausen
2013-12-10 8:53 ` Rajeev kumar
2013-12-10 9:00 ` Lars-Peter Clausen
2013-12-10 11:44 ` Rajeev kumar
2013-12-09 20:24 ` [RFC PATCH 5/5] ASoC: dmaengine: remove compat_request_channel Stephen Warren
2013-12-09 20:38 ` [PATCH 0/5] ASoC: remove dmaengine compat_request_channel Lars-Peter Clausen
2013-12-10 8:21 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A62BC3.1050807@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=swarren@nvidia.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.