From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Date: Mon, 09 Dec 2013 21:14:07 +0000 Subject: Re: [PATCH 2/2] ARM: shmobile: Koelsch: add Ether support Message-Id: <52A640AB.9000105@cogentembedded.com> List-Id: References: <201310310216.28673.sergei.shtylyov@cogentembedded.com> <201310310219.58963.sergei.shtylyov@cogentembedded.com> <5272A98B.3030705@cogentembedded.com> <52A620C5.9030600@cogentembedded.com> In-Reply-To: <52A620C5.9030600@cogentembedded.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org On 12/09/2013 10:57 PM, Sergei Shtylyov wrote: >>>> Register Ether platform device and pin data on the Koelsch board. >>>> Register platform fixup for Micrel KSZ8041 PHY, just like on the Lager board. >>>> Signed-off-by: Sergei Shtylyov >>> Thanks for your patch. Just like on the Lager board we also need to >>> tie in the PHY IRQ pin. >> Not only on the Lager board, BOCK-W also I think. >>> Polling is not good enough when the hardware >>> can do better. Can you please share your PHY IRQ plans with us? >> It's on my agenda now -- will start after I do away with the CAN driver >> and the current Koelsch Ether support. > I have now implemented PHY IRQ support for BOCK-W, Lager, and Koelsch > boards (had to extend the Micrel PHY driver to recognize undocumented > KSZ8041RNLI PHY ID for that) but I must say that the PHY interrupt doesn't get > generated on either of the board and I don't know why yet (I can't rule out > the INTC driver issue); that's bad news. Good news is that even this doesn't > prevent phylib from working properly as it still polls the PHY once a second. Forgot to note that using PHY IRQ on Lager/Koelsch seems quite pointless to me as we're using ETH_LINK signal on these boards and Ether core generates interrupts on the change of this signal using which the driver actually controls packet Rx/Tx; Micrel PHY driver also only enables interrupts on link up/down -- so it seems only useful on BOCK-W where we ignore ETH_LINK and so the driver controls packet Rx/Tx from the phylib's adjust_link() callback. >>> Best, >>> / magnus WBR, Sergei From mboxrd@z Thu Jan 1 00:00:00 1970 From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov) Date: Tue, 10 Dec 2013 01:14:03 +0300 Subject: [PATCH 2/2] ARM: shmobile: Koelsch: add Ether support In-Reply-To: <52A620C5.9030600@cogentembedded.com> References: <201310310216.28673.sergei.shtylyov@cogentembedded.com> <201310310219.58963.sergei.shtylyov@cogentembedded.com> <5272A98B.3030705@cogentembedded.com> <52A620C5.9030600@cogentembedded.com> Message-ID: <52A640AB.9000105@cogentembedded.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 12/09/2013 10:57 PM, Sergei Shtylyov wrote: >>>> Register Ether platform device and pin data on the Koelsch board. >>>> Register platform fixup for Micrel KSZ8041 PHY, just like on the Lager board. >>>> Signed-off-by: Sergei Shtylyov >>> Thanks for your patch. Just like on the Lager board we also need to >>> tie in the PHY IRQ pin. >> Not only on the Lager board, BOCK-W also I think. >>> Polling is not good enough when the hardware >>> can do better. Can you please share your PHY IRQ plans with us? >> It's on my agenda now -- will start after I do away with the CAN driver >> and the current Koelsch Ether support. > I have now implemented PHY IRQ support for BOCK-W, Lager, and Koelsch > boards (had to extend the Micrel PHY driver to recognize undocumented > KSZ8041RNLI PHY ID for that) but I must say that the PHY interrupt doesn't get > generated on either of the board and I don't know why yet (I can't rule out > the INTC driver issue); that's bad news. Good news is that even this doesn't > prevent phylib from working properly as it still polls the PHY once a second. Forgot to note that using PHY IRQ on Lager/Koelsch seems quite pointless to me as we're using ETH_LINK signal on these boards and Ether core generates interrupts on the change of this signal using which the driver actually controls packet Rx/Tx; Micrel PHY driver also only enables interrupts on link up/down -- so it seems only useful on BOCK-W where we ignore ETH_LINK and so the driver controls packet Rx/Tx from the phylib's adjust_link() callback. >>> Best, >>> / magnus WBR, Sergei