From: Fan Du <fan.du@windriver.com>
To: David Miller <davem@davemloft.net>
Cc: <steffen.klassert@secunet.com>, <netdev@vger.kernel.org>
Subject: Re: [PATCHv2 net-next 0/5] pktgen IPsec support
Date: Tue, 10 Dec 2013 09:19:09 +0800 [thread overview]
Message-ID: <52A66C0D.4050409@windriver.com> (raw)
In-Reply-To: <20131209.195854.223825767831436997.davem@davemloft.net>
On 2013年12月10日 08:58, David Miller wrote:
> From: Fan Du<fan.du@windriver.com>
> Date: Fri, 6 Dec 2013 17:53:29 +0800
>
>> Hi, Dave/Steffen
>>
>> Current pktgen IPsec supports only transport/ESP combinnation,
>> and it's buggy before I fixed transformed IP header/length issue
>> a few days ago.
>>
>> This patchset enables user to do almost any IPsec transformation,
>> both transport/tunnel mode, and AH/ESP/IPcomp type.
>>
>> Below configuration has been tested, and using Wireshark could decrypt
>> out plain text in good formation without any checksum/auth errors:
>>
>> Mode/TYPE AH ESP
>> Transport x x
>> Tunnel x x
>>
>> ChangeLog
>> v2:
>> Rebase patchset against newest net-next.
>> Patch1: Remove adding rebundant empty line spotted by Sergei.
>> Patch2: Use only one dst pointing into itself to save space.
>
> I don't like how you've arranged this.
>
> The existing mechanism might be used by someone, and in patch #1
> you just remove it.
>
> It's fixed, but so what? It might useful for someone.
How it could be usable first and then useful for someone before my fix
9e921193884dd85b4cd68aa18598d8c2f9ad85b9
({pktgen, xfrm} Correct xfrm state lock usage when transforming)???
Do you really know what this fix does?
> You must make your changes such that existing setups still
> work, you can't just break things on people.
>
The broken things is the original patch, not this patchset,
any people try to use pktgen with IPsec enabled could spot it's not working.
and any up comping make-working patch won't break anything!
--
浮沉随浪只记今朝笑
--fan
next prev parent reply other threads:[~2013-12-10 1:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-06 9:53 [PATCHv2 net-next 0/5] pktgen IPsec support Fan Du
2013-12-06 9:53 ` [PATCHv2 net-next 1/5] {pktgen, xfrm} Remove original pktgen ipsec fixed configuration Fan Du
2013-12-06 9:53 ` [PATCHv2 net-next 2/5] {pktgen, xfrm} Using "pgset spi xxx" to spedifiy SA for a given flow Fan Du
2013-12-06 9:53 ` [PATCHv2 net-next 3/5] {pktgen,xfrm} Construct skb dst for tunnel mode transformation Fan Du
2013-12-06 9:53 ` [PATCHv2 net-next 4/5] {pktgen, xfrm} Introduce xfrm_state_lookup_byspi for pktgen Fan Du
2013-12-06 9:53 ` [PATCHv2 net-next 5/5] {pktgen, xfrm} Correct xfrm state lock usage when transforming Fan Du
2013-12-10 0:58 ` [PATCHv2 net-next 0/5] pktgen IPsec support David Miller
2013-12-10 1:19 ` Fan Du [this message]
2013-12-10 1:23 ` David Miller
2013-12-10 2:02 ` Fan Du
2013-12-10 2:09 ` David Miller
2013-12-10 2:27 ` Fan Du
2013-12-10 5:49 ` David Miller
2013-12-11 13:42 ` Jamal Hadi Salim
2013-12-13 8:56 ` Fan Du
2013-12-13 12:13 ` Jamal Hadi Salim
2013-12-13 12:22 ` Fan Du
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A66C0D.4050409@windriver.com \
--to=fan.du@windriver.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.