All of lore.kernel.org
 help / color / mirror / Atom feed
From: ChenQi <Qi.Chen@windriver.com>
To: Andrea Adami <andrea.adami@gmail.com>
Cc: Otavio Salvador <otavio@ossystems.com.br>,
	Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/1] image.bbclass: default USE_DEVFS to '1'
Date: Tue, 10 Dec 2013 10:26:17 +0800	[thread overview]
Message-ID: <52A67BC9.4040902@windriver.com> (raw)
In-Reply-To: <CAAQYJAs9j=VJ+L=sLsLG1H1hs3brarksgqtijE8v2Wr35HCSQQ@mail.gmail.com>

On 12/09/2013 09:52 PM, Andrea Adami wrote:
> On Mon, Dec 9, 2013 at 12:52 PM, Otavio Salvador
> <otavio@ossystems.com.br> wrote:
>> Hello,
>>
>> I agree with the commit but ...
>>
>> On Mon, Dec 9, 2013 at 1:17 AM,  <Qi.Chen@windriver.com> wrote:
>>> From: Chen Qi <Qi.Chen@windriver.com>
>>>
>>> Default USE_DEVFS to "1" so that the `makedevs' command is not run
>>> at rootfs time by default. There are mainly two reasons to do so.
>>> 1. This will fix a build failure with initramfs-kexecboot-klibc-image.
>> Can you elaborate this error? is it something we can/should fix?
>>
>>> 2. Most of our images use a filesystem over /dev. Most of the time, it's
>>>     just devtmpfs. So we actually are using a filesystem over /dev.
>>>
>>> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
>>> ---
>>>   meta/classes/image.bbclass |    2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
>>> index cc65e35..b8bd462 100644
>>> --- a/meta/classes/image.bbclass
>>> +++ b/meta/classes/image.bbclass
>>> @@ -77,7 +77,7 @@ PACKAGE_INSTALL_ATTEMPTONLY ?= "${FEATURE_INSTALL_OPTIONAL}"
>>>   # Images are generally built explicitly, do not need to be part of world.
>>>   EXCLUDE_FROM_WORLD = "1"
>>>
>>> -USE_DEVFS ?= "0"
>>> +USE_DEVFS ?= "1"
>>>
>>>   PID = "${@os.getpid()}"
>>>
>>> --
>>> 1.7.9.5
>>>
>>> _______________________________________________
>>> Openembedded-core mailing list
>>> Openembedded-core@lists.openembedded.org
>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>
>>
>> --
>> Otavio Salvador                             O.S. Systems
>> http://www.ossystems.com.br        http://code.ossystems.com.br
>> Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
> The underlying issue here is the extra pass of makedevs  " makedevs:
> No entry for root in search list "
>
> At first I could not understand why that was *not* happening on my
> builds then I realized we set
> IMAGE_DEVICE_TABLES = "" in our machine.conf because we use devtmpfs
> for all images.
>
> qemux86 does instead inherit the default setting of image.bbclass so
> it uses "files/device_table-minimal.txt"
>
>
> Cheers
>
> Andrea
>
>

Thanks for you extra information.

Best Regards,
Chen Qi



  reply	other threads:[~2013-12-10  2:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-09  3:17 [PATCH 0/1] image.bbclass: default USE_DEVFS to '1' Qi.Chen
2013-12-09  3:17 ` [PATCH 1/1] " Qi.Chen
2013-12-09 11:52   ` Otavio Salvador
2013-12-09 13:52     ` Andrea Adami
2013-12-10  2:26       ` ChenQi [this message]
2013-12-10  2:31     ` ChenQi
2013-12-10  4:38       ` Saul Wold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52A67BC9.4040902@windriver.com \
    --to=qi.chen@windriver.com \
    --cc=andrea.adami@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=otavio@ossystems.com.br \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.