From: Andrzej Pietrasiewicz <andrzej.p@samsung.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: USB list <linux-usb@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Felipe Balbi <balbi@ti.com>
Subject: Re: [PATCH] gadget: make USB_CONFIGFS_MASS_STORAGE depend on BLOCK
Date: Tue, 10 Dec 2013 07:47:58 +0100 [thread overview]
Message-ID: <52A6B91E.1010609@samsung.com> (raw)
In-Reply-To: <52A61781.6070708@infradead.org>
W dniu 09.12.2013 20:18, Randy Dunlap pisze:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Make USB_CONFIGFS_MASS_STORAGE depend on BLOCK just like the other
> gadget MASS_STORAGE options do. This fixes the following build errors
> that occur when BLOCK is not enabled:
Already submitted
http://www.spinics.net/lists/linux-usb/msg96739.html
AP
>
> drivers/usb/gadget/storage_common.c: In function 'fsg_lun_open':
> drivers/usb/gadget/storage_common.c:241:3: error: implicit declaration of function 'bdev_logical_block_size' [-Werror=implicit-function-declaration]
> drivers/usb/gadget/storage_common.c:242:3: error: implicit declaration of function 'blksize_bits' [-Werror=implicit-function-declaration]
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Andrzej Pietrasiewicz <andrzej.p@samsung.com>
> Cc: Felipe Balbi <balbi@ti.com>
> ---
> drivers/usb/gadget/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- lnx-313-rc3.orig/drivers/usb/gadget/Kconfig
> +++ lnx-313-rc3/drivers/usb/gadget/Kconfig
> @@ -681,7 +681,7 @@ config USB_CONFIGFS_PHONET
>
> config USB_CONFIGFS_MASS_STORAGE
> boolean "Mass storage"
> - depends on USB_CONFIGFS
> + depends on USB_CONFIGFS && BLOCK
> select USB_F_MASS_STORAGE
> help
> The Mass Storage Gadget acts as a USB Mass Storage disk drive.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2013-12-10 6:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-09 19:18 [PATCH] gadget: make USB_CONFIGFS_MASS_STORAGE depend on BLOCK Randy Dunlap
2013-12-09 19:21 ` Felipe Balbi
2013-12-09 19:27 ` Randy Dunlap
2013-12-09 19:31 ` Felipe Balbi
2013-12-10 6:47 ` Andrzej Pietrasiewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A6B91E.1010609@samsung.com \
--to=andrzej.p@samsung.com \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.