From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42383)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aik@ozlabs.ru>) id 1VqHqX-0000wh-32
	for qemu-devel@nongnu.org; Tue, 10 Dec 2013 02:35:16 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aik@ozlabs.ru>) id 1VqHqP-0000tX-QU
	for qemu-devel@nongnu.org; Tue, 10 Dec 2013 02:35:09 -0500
Received: from mail-pd0-f179.google.com ([209.85.192.179]:51079)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aik@ozlabs.ru>) id 1VqHqP-0000so-Kc
	for qemu-devel@nongnu.org; Tue, 10 Dec 2013 02:35:01 -0500
Received: by mail-pd0-f179.google.com with SMTP id r10so6835628pdi.10
	for <qemu-devel@nongnu.org>; Mon, 09 Dec 2013 23:35:00 -0800 (PST)
Message-ID: <52A6C416.5090605@ozlabs.ru>
Date: Tue, 10 Dec 2013 18:34:46 +1100
From: Alexey Kardashevskiy <aik@ozlabs.ru>
MIME-Version: 1.0
References: <1385364460-24332-1-git-send-email-aik@ozlabs.ru>	<1385364460-24332-3-git-send-email-aik@ozlabs.ru>
	<529DA675.8030705@redhat.com> <529DE041.70006@suse.de>
	<529DE3F0.2050101@redhat.com>
In-Reply-To: <529DE3F0.2050101@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH 2/5] machine: introduce get_fw_dev_path()
 callback
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
Cc: qemu-ppc@nongnu.org, Paul Mackerras <paulus@samba.org>, qemu-devel@nongnu.org, Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>

On 12/04/2013 01:00 AM, Paolo Bonzini wrote:
> Il 03/12/2013 14:44, Andreas Färber ha scritto:
>>>>
>>>> You can check "if (current_machine &&
>>>> current_machine->get_fw_dev_path)", and move current_machine from vl.c
>>>> to hw/qdev/core.c.
>> Please don't encourage moving random stuff into "core" device code.
>>
>> If needed, we can easily add a machine.c, but that should remain
>> softmmu-only.
> 
> Another solution would be to:
> 
> (1) add an interface which contains "get_fw_dev_path".  When
> qdev_get_fw_dev_path is called, walk the QOM tree until an object that
> implements the interface is found.  If none is found, call the bus
> implementation as usual.
> 
> (2) in vl.c, add a way for current_machine to override the /machine
> object.  A 100%-QOMified machine indeed could put a SOC-like Device there.

Is there any good example of a 100%-QOMified machine? I could not find any.


> (3) for spapr, define the machine object to something that implements
> said interface.
> 
> It seemed a bit complicated for this particular problem, but I cannot
> say it's overengineered.

I posted another series, please have a look. I did not find a good example
to copy from so...


> More aspects of the configuration could be moved to the new interface
> over time, for example compat properties.

How would it help?


-- 
Alexey