From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60569) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VqJES-00011b-5p for qemu-devel@nongnu.org; Tue, 10 Dec 2013 04:04:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VqJEJ-0001RG-L4 for qemu-devel@nongnu.org; Tue, 10 Dec 2013 04:03:56 -0500 Received: from mailout2.w1.samsung.com ([210.118.77.12]:48211) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VqJEJ-0001Qs-Eg for qemu-devel@nongnu.org; Tue, 10 Dec 2013 04:03:47 -0500 Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout2.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MXL009G62I8FE30@mailout2.w1.samsung.com> for qemu-devel@nongnu.org; Tue, 10 Dec 2013 09:03:44 +0000 (GMT) Message-id: <52A6D8EE.9050406@samsung.com> Date: Tue, 10 Dec 2013 13:03:42 +0400 From: Fedorov Sergey MIME-version: 1.0 References: <1386657709-23399-1-git-send-email-s.fedorov@samsung.com> In-reply-to: Content-type: text/plain; charset=UTF-8; format=flowed Content-transfer-encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] target-arm: fix TTBCR write masking List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: a.basov@samsung.com, QEMU Developers This patch is a prerequisite for the following up TrustZone support patches. Thanks. Best regards, Sergey Fedorov On 12/10/2013 12:57 PM, Peter Maydell wrote: > On 10 December 2013 06:41, Sergey Fedorov wrote: >> Current implementation is not accurate according to ARMv7-AR reference >> manual. See "B4.1.153 TTBCR, Translation Table Base Control Register, >> VMSA | TTBCR format when using the Long-descriptor translation table >> format". When LPAE feature is supported, EAE, bit[31] selects >> translation descriptor format and, therefore, TTBCR format. >> >> Signed-off-by: Sergey Fedorov > Yeah, when I wrote that I was relying on the fact that all the > valid bits in a short-format descriptor are also valid in the > long-format mask, so correct guest software won't care (the > other bits are UNK/SBZP). However the implementation side > of UNK/SBZP requires us to treat the bits as RAZ/WI, so this > patch is correct. > > Reviewed-by: Peter Maydell > > thanks > -- PMM >