From: David Vrabel <david.vrabel@citrix.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Paul Durrant <paul.durrant@citrix.com>, <xen-devel@lists.xen.org>,
<netdev@vger.kernel.org>, Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCH net] xen-netback: fix abuse of napi budget
Date: Tue, 10 Dec 2013 10:30:13 +0000 [thread overview]
Message-ID: <52A6ED35.7070003@citrix.com> (raw)
In-Reply-To: <1386671136.11925.46.camel@kazak.uk.xensource.com>
On 10/12/13 10:25, Ian Campbell wrote:
> On Tue, 2013-12-10 at 10:16 +0000, Paul Durrant wrote:
>> netback seemed to be somewhat confused about the napi budget parameter and
>> basically ignored it. This patch fixes that, properly limiting the work done
>> in each poll.
>
> What do you mean "ignored", xenvif_tx_submit seems to be tracking and
> testing work_done against the budget.
I have seen this warning in net_rx_action() trigger.
WARN_ON_ONCE(work > weight);
Which means netback wasn't limiting the work done.
David
next prev parent reply other threads:[~2013-12-10 10:30 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-10 10:16 [PATCH net] xen-netback: fix abuse of napi budget Paul Durrant
2013-12-10 10:25 ` Ian Campbell
2013-12-10 10:25 ` Ian Campbell
2013-12-10 10:30 ` David Vrabel [this message]
2013-12-10 10:37 ` Wei Liu
2013-12-10 10:37 ` Wei Liu
2013-12-10 10:44 ` Wei Liu
2013-12-10 10:44 ` Wei Liu
2013-12-10 10:48 ` Paul Durrant
2013-12-10 10:55 ` Wei Liu
2013-12-10 10:55 ` Wei Liu
2013-12-10 11:03 ` Paul Durrant
2013-12-10 11:03 ` Paul Durrant
2013-12-10 10:48 ` Paul Durrant
2013-12-10 10:30 ` David Vrabel
2013-12-10 10:52 ` Paul Durrant
2013-12-10 10:52 ` Paul Durrant
2013-12-10 10:34 ` Wei Liu
2013-12-10 10:34 ` Wei Liu
-- strict thread matches above, loose matches on Subject: below --
2013-12-10 10:16 Paul Durrant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A6ED35.7070003@citrix.com \
--to=david.vrabel@citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=netdev@vger.kernel.org \
--cc=paul.durrant@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.