Re: [Qemu-devel] [PATCH V2] Add Enhanced Three-Speed Ethernet Controller (eTSEC)

[Alexey Kardashevskiy <aik@ozlabs.ru>]

On 12/10/2013 02:15 AM, Alexander Graf wrote:
> 
> On 22.07.2013, at 18:00, Fabien Chouteau <chouteau@adacore.com> wrote:
> 
>> This implementation doesn't include ring priority, TCP/IP Off-Load, QoS.
>>
>> Signed-off-by: Fabien Chouteau <chouteau@adacore.com>
> 
> Thanks, applied to ppc-next. Could you please follow up with a patch that makes this available as -net nic,model=etsec and generate a respective device tree node for it?

This does not compile:

  CC    ppc-softmmu/hw/net/fsl_etsec/rings.o
In file included from /home/alexey/p/qemu/hw/net/fsl_etsec/rings.c:24:0:
/home/alexey/p/qemu/include/net/checksum.h:51:31: error: ‘struct iovec’
declared inside parameter list [-Werror]
/home/alexey/p/qemu/include/net/checksum.h:51:31: error: its scope is only
this definition or declaration, which is probably not what you want [-Werror]
/home/alexey/p/qemu/hw/net/fsl_etsec/rings.c: In function ‘fill_rx_bd’:
/home/alexey/p/qemu/hw/net/fsl_etsec/rings.c:396:5: error: format ‘%llx’
expects argument of type ‘long long unsigned int’, but argument 2 has type
‘hwaddr’ [-Werror=format]
/home/alexey/p/qemu/hw/net/fsl_etsec/rings.c:396:5: error: format ‘%u’
expects argument of type ‘unsigned int’, but argument 3 has type ‘size_t’
[-Werror=format]
/home/alexey/p/qemu/hw/net/fsl_etsec/rings.c: In function ‘etsec_walk_rx_ring’:
/home/alexey/p/qemu/hw/net/fsl_etsec/rings.c:583:28: error: format ‘%d’
expects argument of type ‘int’, but argument 3 has type ‘size_t’
[-Werror=format]
/home/alexey/p/qemu/hw/net/fsl_etsec/rings.c:649:5: error: format ‘%u’
expects argument of type ‘unsigned int’, but argument 2 has type ‘size_t’
[-Werror=format]
cc1: all warnings being treated as errors
make[1]: *** [hw/net/fsl_etsec/rings.o] Error 1
make[1]: *** Waiting for unfinished jobs....
/home/alexey/p/qemu/hw/net/fsl_etsec/etsec.c: In function ‘etsec_realize’:
/home/alexey/p/qemu/hw/net/fsl_etsec/etsec.c:389:53: error: ‘SysBusDevice’
has no member named ‘qdev’
make[1]: *** [hw/net/fsl_etsec/etsec.o] Error 1
make: *** [subdir-ppc-softmmu] Error 2



-- 
Alexey