From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH v6 00/11] libxl: ocaml: improve the bindings Date: Tue, 10 Dec 2013 13:25:31 +0000 Message-ID: <52A7164B.3040501@citrix.com> References: <1386602250-29866-1-git-send-email-rob.hoes@citrix.com> <1386681620.30568.3.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1386681620.30568.3.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: George Dunlap , xen-devel@lists.xen.org, ian.jackson@eu.citrix.com, Rob Hoes , dave.scott@eu.citrix.com List-Id: xen-devel@lists.xenproject.org On 10/12/13 13:20, Ian Campbell wrote: > On Mon, 2013-12-09 at 15:17 +0000, Rob Hoes wrote: >> This series contains version 6 of the remaining patches to fix the OCaml >> bindings to libxl. >> >> The main change compared to version 5 is that we now properly register the >> "user" values (OCaml values that are given to the libxl event system, and >> returned to OCaml in callbacks) with the OCaml GC. > So the release process has moved on sufficiently that I think we need to > consider whether the previous release-ack still stands: > http://thread.gmane.org/gmane.comp.emulators.xen.devel/180254/focus=180383 > > I think the arguments made there still stand, in short it would be > awesome if xapi could move to using libxl on top of 4.4 and the risks > are almost entirely contained within this use case, which cannot be > satisfied by the code as it stands today. Irrespective of the (re)decision about the release ack (which I believe should still stand), Patches 10 and 11 are Coverity fixes from issues caused by the bits of the series committed so far, so should be considered differently if the release ack is rescinded. ~Andrew