From: Julien Grall <julien.grall@linaro.org>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: xen-devel@lists.xenproject.org, tim@xen.org,
stefano.stabellini@citrix.com, patches@linaro.org
Subject: Re: [PATCH v2 04/10] xen/arm: Store p2m type in each page of the guest
Date: Tue, 10 Dec 2013 13:50:15 +0000 [thread overview]
Message-ID: <52A71C17.1070506@linaro.org> (raw)
In-Reply-To: <1386668269.11925.12.camel@kazak.uk.xensource.com>
On 12/10/2013 09:37 AM, Ian Campbell wrote:
> On Tue, 2013-12-10 at 01:55 +0000, Julien Grall wrote:
>> On 12/09/2013 04:53 PM, Ian Campbell wrote:
>>> On Mon, 2013-12-09 at 03:34 +0000, Julien Grall wrote:
>>>> + BUILD_BUG_ON(p2m_max_real_type > (2 << 4));
>>>
>>> 2<<4 is 32.
>>>
>>> I think you want either 1<<4, 2^4 or just 16 (my preference is 16). And
>>
>> Right.
>>
>>> I think it should be >= since the valid values are 0..15 inclusive.
>>
>> No, because p2m_max_real_type won't be store in the p2m, so we can have
>> 16 values [0..15] and p2m_max_real_type will be the 17th (ie 16).
>
> If p2m_max_real_type will be the 17th (ie 16) then the check needs to be
> p2m_max_real_type >= 16.
No because p2m_max_real_type = 16 is valid.
Which is invalid is foo = 16 and p2m_max_real_type = 17.
--
Julien Grall
next prev parent reply other threads:[~2013-12-10 13:50 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-09 3:33 [PATCH v2 00/10] xen/arm: Handle correctly foreign mapping Julien Grall
2013-12-09 3:33 ` [PATCH v2 01/10] xen/arm: Introduce steps in domain_relinquish_resource Julien Grall
2013-12-09 15:42 ` Ian Campbell
2013-12-09 3:33 ` [PATCH v2 02/10] xen/arm: move mfn_to_p2m_entry in arch/arm/p2m.c Julien Grall
2013-12-09 3:34 ` [PATCH v2 03/10] xen/arm: Implement p2m_type_t as an enum Julien Grall
2013-12-09 15:59 ` Ian Campbell
2013-12-09 16:34 ` Julien Grall
2013-12-09 16:54 ` Ian Campbell
2013-12-10 2:02 ` Julien Grall
2013-12-09 3:34 ` [PATCH v2 04/10] xen/arm: Store p2m type in each page of the guest Julien Grall
2013-12-09 16:03 ` Ian Campbell
2013-12-09 16:37 ` Julien Grall
2013-12-09 16:53 ` Ian Campbell
2013-12-10 1:55 ` Julien Grall
2013-12-10 9:37 ` Ian Campbell
2013-12-10 13:50 ` Julien Grall [this message]
2013-12-10 13:58 ` Ian Campbell
2013-12-09 3:34 ` [PATCH v2 05/10] xen/arm: p2m: Extend p2m_lookup parameters to retrieve the p2m type Julien Grall
2013-12-09 16:04 ` Ian Campbell
2013-12-09 3:34 ` [PATCH v2 06/10] xen/arm: Retrieve p2m type in get_page_from_gfn Julien Grall
2013-12-09 16:06 ` Ian Campbell
2013-12-09 16:50 ` Julien Grall
2013-12-09 16:58 ` Ian Campbell
2013-12-10 2:04 ` Julien Grall
2013-12-09 3:34 ` [PATCH v2 07/10] xen/arm: Introduce relinquish_p2m_mapping to remove refcount every mapped page Julien Grall
2013-12-09 16:28 ` Ian Campbell
2013-12-10 1:31 ` Julien Grall
2013-12-10 2:36 ` Julien Grall
2013-12-10 9:34 ` Ian Campbell
2013-12-09 3:34 ` [PATCH v2 08/10] xen/arm: Implement xen_rem_foreign_from_p2m Julien Grall
2013-12-09 16:31 ` Ian Campbell
2013-12-09 17:08 ` Julien Grall
2013-12-09 17:18 ` Ian Campbell
2013-12-10 1:33 ` Julien Grall
2013-12-09 3:34 ` [PATCH v2 09/10] xen/arm: Set foreign page type to p2m_map_foreign Julien Grall
2013-12-09 16:40 ` Ian Campbell
2013-12-10 1:46 ` Julien Grall
2013-12-10 1:51 ` Julien Grall
2013-12-10 9:37 ` Ian Campbell
2013-12-10 14:44 ` Julien Grall
2013-12-10 15:13 ` Ian Campbell
2013-12-09 3:34 ` [PATCH v2 10/10] xen/arm: grant-table: Support read-only mapping Julien Grall
2013-12-09 16:41 ` Ian Campbell
2013-12-09 11:32 ` [PATCH v2 00/10] xen/arm: Handle correctly foreign mapping George Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A71C17.1070506@linaro.org \
--to=julien.grall@linaro.org \
--cc=Ian.Campbell@citrix.com \
--cc=patches@linaro.org \
--cc=stefano.stabellini@citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.