From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yh0-f51.google.com (mail-yh0-f51.google.com [209.85.213.51]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id F2CEFE00785 for ; Tue, 10 Dec 2013 06:47:38 -0800 (PST) Received: by mail-yh0-f51.google.com with SMTP id c41so3841911yho.24 for ; Tue, 10 Dec 2013 06:47:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=YpgLcwpOkf6VL3mId6sFASLNNg52kTZ3KHUw0wj6kAY=; b=N+PJ1teya3IIFcQxd1HfNqd8n/3oL5RCPSytKbsJ47/7uHQF17wPjqEGsewdHPfaJj edBvTpRFM4awVlTA84fC+gNznCNGs5bNia6LOQP5aTo0c/IX2aMFSA+ixuUSIrGjpnT9 TmpTPaIHZHmuKAz4dYz24jeZdk+R+VGCJ3Wkznm0J2eV//pMIs15A7/I42Do8//etDQH VSKLNhpr1lFq4+TSBy8VV6euJoKjTMT+sa/Lmx1OE1Hf3sRv21/Wt9mcKmH9Z2p/lR32 iiPXeTCo03D6e+lC6yUXugKmJUxsYTP4gxgfY6Hby9UjnjrkGlGNkJqis3gCucO5zbFq 6fAw== X-Received: by 10.236.72.200 with SMTP id t48mr17062017yhd.7.1386686857715; Tue, 10 Dec 2013 06:47:37 -0800 (PST) Received: from goober.local ([75.76.228.60]) by mx.google.com with ESMTPSA id r1sm22664444yhf.17.2013.12.10.06.47.37 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 10 Dec 2013 06:47:37 -0800 (PST) Message-ID: <52A72988.6020004@gmail.com> Date: Tue, 10 Dec 2013 08:47:36 -0600 From: John Weber User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:24.0) Gecko/20100101 Thunderbird/24.1.1 MIME-Version: 1.0 To: meta-freescale@yoctoproject.org References: <1386613918-32093-1-git-send-email-rjohnweber@gmail.com> <52A7117E.5000606@mlbassoc.com> In-Reply-To: Subject: Re: [meta-fsl-arm][PATCH] u-boot-fslc: Add branch to SRC_URI and separate recipe files X-BeenThere: meta-freescale@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Usage and development list for the meta-fsl-* layers List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Dec 2013 14:47:39 -0000 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit On 12/10/13 8:25 AM, Otavio Salvador wrote: > On Tue, Dec 10, 2013 at 11:05 AM, Gary Thomas wrote: >> On 2013-12-09 11:31, John Weber wrote: >>> From: Dan McGregor >>> >>> Separate the recipe into two files in the same fashion as the kernel >>> recipes. A u-boot-fslc.inc file contains the common settings for the >>> recipe, and a .bb file contains the settings specific to the version >>> of u-boot to be built (e.g. SRCREV, branch name). >>> >>> In addition, new versions of bitbake require that a branch be specified >>> and that the SRCREV be in the specified branch. Set the branch in the >>> SRC_URI. >>> >>> Branch code based on patch from Dan McGregor >>> >>> Signed-off-by: John Weber >>> --- >>> recipes-bsp/u-boot/u-boot-fslc.inc | 29 >>> +++++++++++++++++++++++++++++ >>> recipes-bsp/u-boot/u-boot-fslc_2013.10.bb | 24 >>> +++--------------------- >>> 2 files changed, 32 insertions(+), 21 deletions(-) >>> create mode 100644 recipes-bsp/u-boot/u-boot-fslc.inc >>> >>> diff --git a/recipes-bsp/u-boot/u-boot-fslc.inc >>> b/recipes-bsp/u-boot/u-boot-fslc.inc >>> new file mode 100644 >>> index 0000000..8457bc5 >>> --- /dev/null >>> +++ b/recipes-bsp/u-boot/u-boot-fslc.inc >>> @@ -0,0 +1,29 @@ >>> +# Copyright (C) 2012, 2013 O.S. Systems Software LTDA. >>> +# Released under the MIT license (see COPYING.MIT for the terms) >>> + >>> +require recipes-bsp/u-boot/u-boot.inc >>> + >>> +DESCRIPTION = "U-boot bootloader for Freescale ARM platforms" >>> +LICENSE = "GPLv2+" >>> +LIC_FILES_CHKSUM = >>> "file://Licenses/README;md5=025bf9f768cbcb1a165dbe1a110babfb" >>> +COMPATIBLE_MACHINE = "(mxs|mx3|mx5|mx6|vf60)" >>> + >>> +DEPENDS_mxs += "elftosb-native openssl-native" >>> + >>> +PROVIDES += "u-boot" >>> + >>> +GITBRANCH ??= "master" >>> + >>> +SRC_URI = "git://github.com/Freescale/u-boot-imx.git;tag=${BITBRANCH}" >> >> Don't use tag=, use branch=. The use of tags breaks the ability to run >> with BB_NO_NETWORK and private/local source mirrors. >> >> Also, why not call it SRCBRANCH, following the revision name of SRCREV >> already >> used by bitbake? > I second this changes; John, can you update this accordinly? > v3 is sent.