From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Vrabel Subject: Re: [PATCH 1/2] evtchn/fifo: initialize priority when events are bound Date: Tue, 10 Dec 2013 14:54:52 +0000 Message-ID: <52A72B3C.7080009@citrix.com> References: <1386683820-9834-1-git-send-email-david.vrabel@citrix.com> <1386683820-9834-2-git-send-email-david.vrabel@citrix.com> <52A73830020000780010BE4E@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1VqOi8-00056c-UI for xen-devel@lists.xenproject.org; Tue, 10 Dec 2013 14:54:57 +0000 In-Reply-To: <52A73830020000780010BE4E@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: xen-devel , Keir Fraser List-Id: xen-devel@lists.xenproject.org On 10/12/13 14:50, Jan Beulich wrote: >>>> On 10.12.13 at 14:56, David Vrabel wrote: >> From: David Vrabel >> >> Event channel ports that are reused or that were not in the initial >> bucket would have a non-default priority. >> >> Add an init evtchn_port_op hook and use this to set the priority when >> an event channel is bound. >> >> Within this new evtchn_fifo_init() call, also check if the event is >> already on a queue and print a warning, as this event may have its >> first event delivered on a queue with the wrong VCPU or priority. >> This guest is expected to prevent this (if it cares) by not unbinding >> events that are still linked. >> > > Reported-by: Jan Beulich Yes, sorry. Not the first time I've not properly attributed someone. I shall have to be more careful in future. >> Signed-off-by: David Vrabel > > Reviewed-by: Jan Beulich Thanks! David