All of lore.kernel.org
 help / color / mirror / Atom feed
From: santosh.shilimkar@ti.com (Santosh Shilimkar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/2] usb: phy: Add keystone usb phy driver
Date: Tue, 10 Dec 2013 10:14:44 -0500	[thread overview]
Message-ID: <52A72FE4.4020105@ti.com> (raw)
In-Reply-To: <20131210025405.GB20090@saruman.home>

On Monday 09 December 2013 09:54 PM, Balbi, Felipe wrote:
> Hi,
> 
> On Mon, Dec 09, 2013 at 05:17:04PM -0500, WingMan Kwok wrote:
>> +	ret = usb_add_phy_dev(&k_phy->usb_phy_gen.phy);
>> +	if (ret)
>> +		return ret;
>> +	k_phy->usb_phy_gen.phy.init = keystone_usbphy_init;
>> +	k_phy->usb_phy_gen.phy.shutdown = keystone_usbphy_shutdown;
> 
> this *must* be initialized before adding the PHY to the subsystem. So
> these two lines must be moved before usb_add_phy_dev().
> 
Make sense. Probably its good idea to repost the $subject patch with
above as well as other delay related comment.

Regards,
Santosh

  reply	other threads:[~2013-12-10 15:14 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-09 22:17 [PATCH v3 0/2] Kesytone II USB host and PHY drivers WingMan Kwok
2013-12-09 22:17 ` [PATCH v3 1/2] usb: dwc3: Add Keystone specific glue layer WingMan Kwok
2013-12-10  2:51   ` Felipe Balbi
2013-12-10 15:11     ` Santosh Shilimkar
2013-12-12 17:48       ` Felipe Balbi
2013-12-12 19:36         ` Santosh Shilimkar
2013-12-12 19:41           ` Felipe Balbi
2013-12-12 19:52             ` Santosh Shilimkar
2013-12-09 22:17 ` [PATCH v3 2/2] usb: phy: Add keystone usb phy driver WingMan Kwok
2013-12-10  2:54   ` Felipe Balbi
2013-12-10 15:14     ` Santosh Shilimkar [this message]
2013-12-12 17:20       ` Kwok, WingMan
2013-12-12 17:47         ` Felipe Balbi
2013-12-10  3:09   ` Roger Quadros
2013-12-12 17:24     ` Kwok, WingMan
2013-12-10  4:47   ` Felipe Balbi
2013-12-10 15:17     ` Santosh Shilimkar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52A72FE4.4020105@ti.com \
    --to=santosh.shilimkar@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.