All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: memcpy() in lib/fdt.c
Date: Tue, 10 Dec 2013 16:55:44 +0100	[thread overview]
Message-ID: <52A73980.80808@gmail.com> (raw)
In-Reply-To: <20131210153823.GG22356@rocoto.smurfnet.nu>

[-- Attachment #1: Type: text/plain, Size: 991 bytes --]

Go ahead
On 10.12.2013 16:38, Leif Lindholm wrote:
> Hi,
> 
> There is a typo in fdt.c, invoking memcpy() rather than grub_memcpy().
> Suggested trivial fix:
> 
> diff --git a/grub-core/lib/fdt.c b/grub-core/lib/fdt.c
> index 9c886fc..9f34dc7 100644
> --- a/grub-core/lib/fdt.c
> +++ b/grub-core/lib/fdt.c
> @@ -219,8 +219,8 @@ static int rearrange_blocks (void *fdt, unsigned int clearan
>    grub_fdt_set_off_dt_strings (fdt, off_dt_strings);
>  
>    /* Copy reordered blocks back to fdt. */
> -  memcpy (fdt_ptr + off_mem_rsvmap, tmp_fdt + off_mem_rsvmap,
> -         grub_fdt_get_totalsize (fdt) - off_mem_rsvmap);
> +  grub_memcpy (fdt_ptr + off_mem_rsvmap, tmp_fdt + off_mem_rsvmap,
> +               grub_fdt_get_totalsize (fdt) - off_mem_rsvmap);
>  
>    grub_free(tmp_fdt);
>    return 0;
> 
> 
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
> 



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 291 bytes --]

      reply	other threads:[~2013-12-10 15:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-10 15:38 memcpy() in lib/fdt.c Leif Lindholm
2013-12-10 15:55 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52A73980.80808@gmail.com \
    --to=phcoder@gmail.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.