From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: kern/efi/mm.c - MAX_USABLE_ADDRESS
Date: Tue, 10 Dec 2013 17:00:28 +0100 [thread overview]
Message-ID: <52A73A9C.8090901@gmail.com> (raw)
In-Reply-To: <20131210145940.GF22356@rocoto.smurfnet.nu>
[-- Attachment #1: Type: text/plain, Size: 1083 bytes --]
On 10.12.2013 15:59, Leif Lindholm wrote:
> On Mon, Dec 09, 2013 at 10:17:20PM +0100, Leif Lindholm wrote:
>> On Mon, Dec 09, 2013 at 08:08:39PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
>>>> A simple fix would be to just stack the ifdefs, but a better one might
>>>> be to move the define to one of <cpu/efi/memory.h> (which is currently
>>>> a dummy for all platforms, simply including <efi/memory.h>) or types.h.
>>>>
>>> cpu/efi/memory.h is a possibility. cpu/types.h isn't because it's, at
>>> least partially, EFI limitation (due to EFI bugs), not CPU.
>>
>> Ah, ok - that makes sense then.
>
> How about the attached?
>
You need to prefix define with GRUB_EFI_ as soon as it's a global define
and not limited to one file. Otherwise patch looks good. Can you send
corrected version?
> Compile tested for arm/arm64/i386/x86_64, runtime tested on arm64.
>
> /
> Leif
>
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 291 bytes --]
next prev parent reply other threads:[~2013-12-10 16:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-09 17:30 kern/efi/mm.c - MAX_USABLE_ADDRESS Leif Lindholm
2013-12-09 19:08 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-12-09 19:43 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-12-09 21:26 ` Leif Lindholm
2013-12-09 21:17 ` Leif Lindholm
2013-12-10 14:59 ` Leif Lindholm
2013-12-10 16:00 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
2013-12-10 17:15 ` Leif Lindholm
2013-12-10 18:00 ` Vladimir 'φ-coder/phcoder' Serbinenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A73A9C.8090901@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.