From: Eric Blake <eblake@redhat.com>
To: Amos Kong <akong@redhat.com>, qemu-devel@nongnu.org
Cc: amit.shah@redhat.com, varadgautam@gmail.com, anthony@codemonkey.ws
Subject: Re: [Qemu-devel] [PATCH RFC 2/2] rng-egd: introduce a parameter to set buffer size
Date: Tue, 10 Dec 2013 09:58:19 -0700 [thread overview]
Message-ID: <52A7482B.302@redhat.com> (raw)
In-Reply-To: <1386598213-8156-3-git-send-email-akong@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 899 bytes --]
On 12/09/2013 07:10 AM, Amos Kong wrote:
> This patch makes the buffer size configurable, the max
> buffer size is 65536.
>
> -object rng-egd,chardev=chr0,id=rng0,buf_size=1024
>
> Signed-off-by: Amos Kong <akong@redhat.com>
> ---
> backends/rng-egd.c | 24 +++++++++++++++++++++---
> 1 file changed, 21 insertions(+), 3 deletions(-)
> @@ -281,6 +298,7 @@ static void rng_egd_init(Object *obj)
> object_property_add_str(obj, "chardev",
> rng_egd_get_chardev, rng_egd_set_chardev,
> NULL);
> + object_property_add_str(obj, "buf_size", NULL, rng_egd_set_buf_size, NULL);
> }
Will libvirt ever need to set this property? And is it easily
discoverable whether qemu supports or lacks this property?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]
next prev parent reply other threads:[~2013-12-10 16:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-09 14:10 [Qemu-devel] [PATCH RFC 0/2] improve rng-egd perf Amos Kong
2013-12-09 14:10 ` [Qemu-devel] [PATCH RFC 1/2] rng-egd: improve egd backend performance Amos Kong
2013-12-16 16:36 ` Amit Shah
2013-12-16 23:19 ` Anthony Liguori
2013-12-17 5:52 ` Amit Shah
2013-12-17 7:03 ` Amos Kong
2013-12-17 7:47 ` Markus Armbruster
2013-12-17 10:32 ` Amit Shah
2013-12-18 10:05 ` Giuseppe Scrivano
2013-12-24 9:58 ` Varad Gautam
2014-01-08 9:14 ` Amos Kong
2014-01-08 16:23 ` Amit Shah
2014-01-10 2:30 ` Amos Kong
2013-12-09 14:10 ` [Qemu-devel] [PATCH RFC 2/2] rng-egd: introduce a parameter to set buffer size Amos Kong
2013-12-10 16:58 ` Eric Blake [this message]
2013-12-12 2:55 ` Amos Kong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A7482B.302@redhat.com \
--to=eblake@redhat.com \
--cc=akong@redhat.com \
--cc=amit.shah@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
--cc=varadgautam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.