From: Antonio Quartulli <antonio@meshcoding.com>
To: Eliad Peller <eliad@wizery.com>,
Antonio Quartulli <antonio@open-mesh.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [RFC 1/2] mac80211: iterate over vif using RCU
Date: Tue, 10 Dec 2013 18:34:41 +0100 [thread overview]
Message-ID: <52A750B1.8000303@meshcoding.com> (raw)
In-Reply-To: <CAB3XZEe9ZGvn+1P6-eb-vq2yfkx97QheZ002bYYbN0wtYNqK_g@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 839 bytes --]
On 10/12/13 18:23, Eliad Peller wrote:
> On Tue, Dec 10, 2013 at 7:08 PM, Antonio Quartulli
> <antonio@open-mesh.com> wrote:
>>>> Moreover, why do we use list_for_each_entry_safe() is ieee80211_iter_keys() if
>>>> the list cannot be altered (pointer to key is not passed to iter() so we should
>>>> be sure that nobody is going to invoke list_del())?
>>>
>>> see the documentation of ieee80211_remove_key():
>>
>> This function does not exist anymore
>>
> it does seem to exist here :)
> https://git.kernel.org/cgit/linux/kernel/git/linville/wireless-next.git/tree/include/net/mac80211.h
>
ops you are right. I got confused because I was discussing about that
function some days ago: it is not used by any driver, so it could be
removed.
Therefore it should not really be a problem here.
--
Antonio Quartulli
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2013-12-10 17:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-10 16:39 [RFC 1/2] mac80211: iterate over vif using RCU Antonio Quartulli
2013-12-10 16:39 ` [RFC 2/2] mac80211: Use RCU to handle local->key_list Antonio Quartulli
2013-12-10 17:05 ` [RFC 1/2] mac80211: iterate over vif using RCU Eliad Peller
2013-12-10 17:08 ` Antonio Quartulli
2013-12-10 17:23 ` Eliad Peller
2013-12-10 17:34 ` Antonio Quartulli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A750B1.8000303@meshcoding.com \
--to=antonio@meshcoding.com \
--cc=antonio@open-mesh.com \
--cc=eliad@wizery.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.