From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yh0-f48.google.com (mail-yh0-f48.google.com [209.85.213.48]) by kanga.kvack.org (Postfix) with ESMTP id E061F6B0035 for ; Tue, 10 Dec 2013 17:52:24 -0500 (EST) Received: by mail-yh0-f48.google.com with SMTP id f73so4485873yha.35 for ; Tue, 10 Dec 2013 14:52:24 -0800 (PST) Received: from mail.zytor.com (terminus.zytor.com. [2001:1868:205::10]) by mx.google.com with ESMTPS id r49si15287217yho.217.2013.12.10.14.52.23 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 10 Dec 2013 14:52:23 -0800 (PST) Message-ID: <52A79B0D.4090303@zytor.com> Date: Tue, 10 Dec 2013 14:51:57 -0800 From: "H. Peter Anvin" MIME-Version: 1.0 Subject: Re: [PATCH] mm,x86: fix span coverage in e820_all_mapped() References: <52A6D9B0.7040506@huawei.com> <52A787D0.2070400@zytor.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Yinghai Lu Cc: Xishi Qiu , Thomas Gleixner , Ingo Molnar , the arch/x86 maintainers , Linn Crosetto , Pekka Enberg , LKML , Andrew Morton , Linux MM On 12/10/2013 01:52 PM, Yinghai Lu wrote: >> >> What happens if it spans more than two regions? > > [A, B), [B+1, C), [C+1, D) ? > start in [A, B), and end in [C+1, D). > > old code: > first with [A, B), start set to B. > then with [B+1, C), start still keep as B. > then with [C+1, D), start still keep as B. > at last still return 0...aka not_all_mapped. > > old code is still right. > Why not_all_mapped? -hpa -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751172Ab3LJWwd (ORCPT ); Tue, 10 Dec 2013 17:52:33 -0500 Received: from terminus.zytor.com ([198.137.202.10]:53624 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750823Ab3LJWwc (ORCPT ); Tue, 10 Dec 2013 17:52:32 -0500 Message-ID: <52A79B0D.4090303@zytor.com> Date: Tue, 10 Dec 2013 14:51:57 -0800 From: "H. Peter Anvin" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-Version: 1.0 To: Yinghai Lu CC: Xishi Qiu , Thomas Gleixner , Ingo Molnar , the arch/x86 maintainers , Linn Crosetto , Pekka Enberg , LKML , Andrew Morton , Linux MM Subject: Re: [PATCH] mm,x86: fix span coverage in e820_all_mapped() References: <52A6D9B0.7040506@huawei.com> <52A787D0.2070400@zytor.com> In-Reply-To: X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/10/2013 01:52 PM, Yinghai Lu wrote: >> >> What happens if it spans more than two regions? > > [A, B), [B+1, C), [C+1, D) ? > start in [A, B), and end in [C+1, D). > > old code: > first with [A, B), start set to B. > then with [B+1, C), start still keep as B. > then with [C+1, D), start still keep as B. > at last still return 0...aka not_all_mapped. > > old code is still right. > Why not_all_mapped? -hpa