From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53913)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VqYiv-0008AL-06
	for qemu-devel@nongnu.org; Tue, 10 Dec 2013 20:36:33 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VqYim-0000Fj-JT
	for qemu-devel@nongnu.org; Tue, 10 Dec 2013 20:36:24 -0500
Received: from mail-pb0-x230.google.com ([2607:f8b0:400e:c01::230]:61694)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VqYim-0000Fc-CB
	for qemu-devel@nongnu.org; Tue, 10 Dec 2013 20:36:16 -0500
Received: by mail-pb0-f48.google.com with SMTP id md12so8872571pbc.7
	for <qemu-devel@nongnu.org>; Tue, 10 Dec 2013 17:36:15 -0800 (PST)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <52A7C18A.8080400@twiddle.net>
Date: Tue, 10 Dec 2013 17:36:10 -0800
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1385580849-10777-1-git-send-email-ehabkost@redhat.com>	<1385580849-10777-2-git-send-email-ehabkost@redhat.com>
	<20131210185506.GF27737@otherpad.lan.raisama.net>
In-Reply-To: <20131210185506.GF27737@otherpad.lan.raisama.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/7 v2] target-i386: Eliminate CONFIG_KVM
 #ifdefs
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>, qemu-devel@nongnu.org, =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>
Cc: Igor Mammedov <imammedo@redhat.com>, Jiri Denemark <jdenemar@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>

On 12/10/2013 10:55 AM, Eduardo Habkost wrote:
> The compiler is capable of eliminating the KVM-specific function calls
> as long as the calling function has an assert(kvm_enabled()) line, so we
> don't need to wrap all KVM-specific code inside #ifdefs.

Really?  In tcg/tcg.h we force NDEBUG if not CONFIG_TCG_DEBUG, which makes
assert expand to nothing.  This statement may be true for some files, but
almost everything under target-i386 includes tcg.h.

Although I know we've talked within glibc and gcc the de-optimization of
missing out on assert info, and how we ought to use __builtin_gcc_unreachable
in order to retain that, we've still not done anything official with <assert.h>.

That said, I don't disagree with the changes, if they work with a forced
-DNDEBUG, i.e. unreachable code that still compiles.


r~