From: Yang Yingliang <yangyingliang@huawei.com>
To: David Laight <David.Laight@ACULAB.COM>
Cc: <davem@davemloft.net>, <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 6/6] net_sched: make macro be enclosed in parenthesis
Date: Wed, 11 Dec 2013 10:16:35 +0800 [thread overview]
Message-ID: <52A7CB03.2000209@huawei.com> (raw)
In-Reply-To: <AE90C24D6B3A694183C094C60CF0A2F6026B7477@saturn3.aculab.com>
On 2013/12/10 21:01, David Laight wrote:
>> #define SKIP_NONLOCAL(skb) \
>> +({ \
>> if (unlikely(skb->sk == NULL)) { \
>> *err = -1; \
>> return; \
>> - }
>> + } \
>> +})
>
> That one should be lined up against the fence and shot :-)
>
>
Hmm, not fully understand, did you mean that:
#define SKIP_NONLOCAL(skb) ({ \
if (unlikely(skb->sk == NULL)) { \
*err = -1; \
return; \
} \
})
next prev parent reply other threads:[~2013-12-11 2:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-10 12:55 [PATCH net-next 0/6] net_sched: clean up some chekpatch errors Yang Yingliang
2013-12-10 12:55 ` [PATCH net-next 1/6] net_sched: remove unnecessary parentheses while return Yang Yingliang
2013-12-11 3:46 ` David Miller
2013-12-10 12:55 ` [PATCH net-next 2/6] net_sched: cls_bpf: use tabs to do indent Yang Yingliang
2013-12-11 3:46 ` David Miller
2013-12-10 12:55 ` [PATCH net-next 3/6] net_sched: change "foo* bar" to "foo *bar" Yang Yingliang
2013-12-11 3:46 ` David Miller
2013-12-10 12:55 ` [PATCH net-next 4/6] net_sched: add space around '>' and before '(' Yang Yingliang
2013-12-11 3:46 ` David Miller
2013-12-10 12:55 ` [PATCH net-next 5/6] net_sched: sfq: put sfq_unlink in a do - while loop Yang Yingliang
2013-12-11 3:47 ` David Miller
2013-12-10 12:55 ` [PATCH net-next 6/6] net_sched: make macro be enclosed in parenthesis Yang Yingliang
2013-12-10 13:01 ` David Laight
2013-12-11 2:16 ` Yang Yingliang [this message]
2013-12-11 3:49 ` David Miller
2013-12-11 7:17 ` [PATCH net-next] net_sched: expand control flow of macro SKIP_NONLOCAL Yang Yingliang
2013-12-11 17:29 ` David Miller
2013-12-11 10:20 ` [PATCH net-next 6/6] net_sched: make macro be enclosed in parenthesis David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A7CB03.2000209@huawei.com \
--to=yangyingliang@huawei.com \
--cc=David.Laight@ACULAB.COM \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.