All of lore.kernel.org
 help / color / mirror / Atom feed
From: ChenQi <Qi.Chen@windriver.com>
To: "Burton, Ross" <ross.burton@intel.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/1] libgcrypt: fix compile error with '-O2' in sysroot path
Date: Wed, 11 Dec 2013 10:59:25 +0800	[thread overview]
Message-ID: <52A7D50D.2000907@windriver.com> (raw)
In-Reply-To: <CAJTo0LYKS7g6R96973EYm48YvJJnVxc0w3+qC3Zi2VDb4LWFyA@mail.gmail.com>

On 12/10/2013 07:40 PM, Burton, Ross wrote:
> On 10 December 2013 11:37, Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
>>> I thought it would do no harm. And I will send this patch to upstream,
>>> so it might be a little strange that I only modify the Makefile.am file
>>> even if Makefile.in has the same problem.
>> It can actually be harmful since the modification time of Makefile.in
>> can be after the time for Makefile.am and things can go "very wrong"
>> with autotools when that happens :(
> Another good reason not to modify the Makefile.in is that being a
> generated file, updating automake can change how it is generated, so
> the patch doesn't apply anymore.
>
> Ross
>
>

Hi All,

Thanks for your explanation. I'll send out a V2.

Best Regards,
Chen Qi


      reply	other threads:[~2013-12-11  2:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-05  8:55 [PATCH 0/1] libgcrypt: fix compile error with '-O2' in sysroot path Qi.Chen
2013-12-05  8:55 ` [PATCH 1/1] " Qi.Chen
2013-12-05 22:41   ` Saul Wold
2013-12-06  1:30     ` ChenQi
2013-12-10 11:37       ` Richard Purdie
2013-12-10 11:40         ` Burton, Ross
2013-12-11  2:59           ` ChenQi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52A7D50D.2000907@windriver.com \
    --to=qi.chen@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=ross.burton@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.