From mboxrd@z Thu Jan 1 00:00:00 1970 From: Masami Hiramatsu Subject: Re: [PATCH -tip v5 13/18] notifier: Use NOKPROBE_SYMBOL macro in notifier Date: Wed, 11 Dec 2013 12:04:38 +0900 Message-ID: <52A7D646.2040904@hitachi.com> References: <20131209104717.13397.8864.stgit@kbuild-fedora.novalocal> <20131209104748.13397.52431.stgit@kbuild-fedora.novalocal> <52A7D4C0.7060700@hitachi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: Received: from mail4.hitachi.co.jp ([133.145.228.5]:55489 "EHLO mail4.hitachi.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751342Ab3LKDEp (ORCPT ); Tue, 10 Dec 2013 22:04:45 -0500 In-Reply-To: <52A7D4C0.7060700@hitachi.com> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Ingo Molnar Cc: linux-arch@vger.kernel.org, Ananth N Mavinakayanahalli , Sandeepa Prabhu , x86@kernel.org, lkml , "Steven Rostedt (Red Hat)" , systemtap@sourceware.org, "David S. Miller" (2013/12/11 11:58), Masami Hiramatsu wrote: > (2013/12/09 19:47), Masami Hiramatsu wrote: >> Use NOKPROBE_SYMBOL macro to protect functions from >> kprobes instead of __kprobes annotation in notifier. > > Ah, this must just removes __kprobes since we don't use notify_die > for kprobes anymore... Oops, NO. kprobes generically still using the exception notifier to handle GPF in the handler even on x86... For safety, I'd like to keep it as it is until all dependency is removed. Thank you, -- Masami HIRAMATSU IT Management Research Dept. Linux Technology Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: masami.hiramatsu.pt@hitachi.com