From: Hans Verkuil <hansverk@cisco.com>
To: Kamil Debski <k.debski@samsung.com>
Cc: "'Hans Verkuil'" <hverkuil@xs4all.nl>,
linux-media@vger.kernel.org,
Marek Szyprowski <m.szyprowski@samsung.com>,
pawel@osciak.com, laurent.pinchart@ideasonboard.com,
awalls@md.metrocast.net, kyungmin.park@samsung.com,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
g.liakhovetski@gmx.de, "'Hans Verkuil'" <hans.verkuil@cisco.com>,
"'Lad, Prabhakar'" <prabhakar.csengg@gmail.com>,
Tomasz Stanislawski <t.stanislaws@samsung.com>
Subject: Re: [RFCv4 PATCH 7/8] vb2: return ENODATA in start_streaming in case of too few buffers.
Date: Wed, 11 Dec 2013 11:28:03 +0100 [thread overview]
Message-ID: <52A83E33.9010107@cisco.com> (raw)
In-Reply-To: <00c101cef65b$8abd4640$a037d2c0$%debski@samsung.com>
Hi Kamil,
On 12/11/13 11:27, Kamil Debski wrote:
> Hi,
>
>> From: Hans Verkuil [mailto:hverkuil@xs4all.nl]
>> Sent: Tuesday, December 10, 2013 8:52 AM
>>
>> As Guennadi mentioned in his review, ENODATA will be replaced by
>> ENOBUFS, which is more appropriate.
>>
>> Prabhakar, Kamil, Tomasz, are you OK with this patch provided
>> s/ENODATA/ENOBUFS/ ?
>
> The patch looks good. However, shouldn't the documentation be changed too?
>
> Now it says: [1]
> "(...) Accordingly the output hardware is disabled, no video signal is
> produced until VIDIOC_STREAMON has been called. The ioctl will succeed
> only when at least one output buffer is in the incoming queue. (...)"
>
> If I understand correctly, now the ioctl will succeed with no buffers
> queued.
That's true *only* for drivers using vb2. As long as not all drivers are
converted (which is a *very* long-term project) I don't think i can change
the documentation.
Regards,
Hans
> Apart from the above you have my ack.
>
> Acked-by: Kamil Debski <k.debski@samsung.com>
>
> Best wishes,
>
next prev parent reply other threads:[~2013-12-11 10:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-09 13:43 [RFCv4 PATCH 0/8] vb2: various cleanups and improvements Hans Verkuil
2013-12-09 13:43 ` [RFCv4 PATCH 1/8] vb2: push the mmap semaphore down to __buf_prepare() Hans Verkuil
2013-12-09 13:43 ` [RFCv4 PATCH 2/8] vb2: simplify qbuf/prepare_buf by removing callback Hans Verkuil
2013-12-09 13:43 ` [RFCv4 PATCH 3/8] vb2: fix race condition between REQBUFS and QBUF/PREPARE_BUF Hans Verkuil
2013-12-09 13:43 ` [RFCv4 PATCH 4/8] vb2: remove the 'fileio = NULL' hack Hans Verkuil
2013-12-09 13:43 ` [RFCv4 PATCH 5/8] vb2: retry start_streaming in case of insufficient buffers Hans Verkuil
2013-12-10 6:38 ` Guennadi Liakhovetski
2013-12-10 7:42 ` Hans Verkuil
2013-12-09 13:43 ` [RFCv4 PATCH 6/8] vb2: don't set index, don't start streaming for write() Hans Verkuil
2013-12-09 13:43 ` [RFCv4 PATCH 7/8] vb2: return ENODATA in start_streaming in case of too few buffers Hans Verkuil
2013-12-10 7:48 ` Guennadi Liakhovetski
2013-12-10 7:51 ` Hans Verkuil
2013-12-10 9:56 ` Prabhakar Lad
2013-12-10 12:17 ` Prabhakar Lad
2013-12-11 10:27 ` Kamil Debski
2013-12-11 10:28 ` Hans Verkuil [this message]
2013-12-09 13:43 ` [RFCv4 PATCH 8/8] vb2: Improve file I/O emulation to handle buffers in any order Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A83E33.9010107@cisco.com \
--to=hansverk@cisco.com \
--cc=awalls@md.metrocast.net \
--cc=g.liakhovetski@gmx.de \
--cc=hans.verkuil@cisco.com \
--cc=hverkuil@xs4all.nl \
--cc=k.debski@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=pawel@osciak.com \
--cc=prabhakar.csengg@gmail.com \
--cc=s.nawrocki@samsung.com \
--cc=t.stanislaws@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.