From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Date: Wed, 11 Dec 2013 15:39:05 +0000 Subject: Re: [PATCH] micrel: add support for KSZ8041RNLI Message-Id: <52A88719.4000406@cogentembedded.com> List-Id: References: <201312100220.42153.sergei.shtylyov@cogentembedded.com> <20131210.222639.2106376982664488750.davem@davemloft.net> In-Reply-To: <20131210.222639.2106376982664488750.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: David Miller Cc: netdev@vger.kernel.org, linux-sh@vger.kernel.org Hello. On 11-12-2013 7:26, David Miller wrote: >> Renesas R-Car development boards use KSZ8041RNLI PHY which for some reason has >> ID of 0x00221537 that is not documented for KSZ8041-family PHYs and does not >> match the documented ID of 0x0022151x (where 'x' is the revision). We have >> to add the new #define PHY_ID_* and new ksphy_driver[] entry, almost the same >> as KSZ8041 one, differing only in the 'phy_id' and 'name' fields. >> Signed-off-by: Sergei Shtylyov >> --- >> This patch is atop of DaveM's 'net-next.git' repo. > You said something to Geert about "Though it's not the last version > probably..." are you talking about this patch needing more revisions? Well, maybe. I half-expected some criticisms. My changelog was somewhat tautological, and I'm not sure about the ID mask, perhaps it should be 0x00ffffff to also cover the revision field. Since the ID is totally undocumented, I'm just not very sure how to deal with it properly. > If so, please make it explicit that you are posting something that is > just for feedback and not applying by using "RFC" in the subject line. At the time of sending I intended it to be applied, if no negative comments would have been posted. > Thanks. WBR, Sergei From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH] micrel: add support for KSZ8041RNLI Date: Wed, 11 Dec 2013 19:39:05 +0400 Message-ID: <52A88719.4000406@cogentembedded.com> References: <201312100220.42153.sergei.shtylyov@cogentembedded.com> <20131210.222639.2106376982664488750.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, linux-sh@vger.kernel.org To: David Miller Return-path: Received: from mail-bk0-f52.google.com ([209.85.214.52]:54736 "EHLO mail-bk0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751604Ab3LKPjG (ORCPT ); Wed, 11 Dec 2013 10:39:06 -0500 Received: by mail-bk0-f52.google.com with SMTP id u14so391133bkz.11 for ; Wed, 11 Dec 2013 07:39:05 -0800 (PST) In-Reply-To: <20131210.222639.2106376982664488750.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: Hello. On 11-12-2013 7:26, David Miller wrote: >> Renesas R-Car development boards use KSZ8041RNLI PHY which for some reason has >> ID of 0x00221537 that is not documented for KSZ8041-family PHYs and does not >> match the documented ID of 0x0022151x (where 'x' is the revision). We have >> to add the new #define PHY_ID_* and new ksphy_driver[] entry, almost the same >> as KSZ8041 one, differing only in the 'phy_id' and 'name' fields. >> Signed-off-by: Sergei Shtylyov >> --- >> This patch is atop of DaveM's 'net-next.git' repo. > You said something to Geert about "Though it's not the last version > probably..." are you talking about this patch needing more revisions? Well, maybe. I half-expected some criticisms. My changelog was somewhat tautological, and I'm not sure about the ID mask, perhaps it should be 0x00ffffff to also cover the revision field. Since the ID is totally undocumented, I'm just not very sure how to deal with it properly. > If so, please make it explicit that you are posting something that is > just for feedback and not applying by using "RFC" in the subject line. At the time of sending I intended it to be applied, if no negative comments would have been posted. > Thanks. WBR, Sergei