Re: [Qemu-devel] [PATCH v2] char: restore read callback on a reattached (hotplug) chardev

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1373 bytes --]

On 12/11/2013 02:47 AM, Gal Hammer wrote:
> Fix a bug that was introduced in commit 386a5a1e. A removal of a device
> set the chr handlers to NULL. However when the device is plugged back,
> its read callback is not restored so data can't be transfter from the

s/transfter/transferred/

> host to the guest via the virtio-serial port.
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1027181

The S-o-B tag below, and the commit message up to here is fine...

> 
> V2: - do not call chr_update_read_handler on device removal.
>     - add asserts to verify chr_update_read_handler is not called
>       with an assigned fd_in_tag to prevent fd leaks.
>     - update fd and udp backends' chr_update_read_handler function
>       so it won't remove fd_in to prevent a double release.

...whereas this version information belongs better...

> 
> Signed-off-by: Gal Hammer <ghammer@redhat.com>
> ---

...here, after the --- separator.  It's useful information to reviewers,
but in this location, 'git am' will strip it, as in the long run,
someone reading 'git log' history doesn't care about how many revisions
a patch took or what changed from the earlier versions of the patch,
since none of the earlier versions are stored in git.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]