From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46968)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lig.fnst@cn.fujitsu.com>) id 1Vqtdu-0000GG-6B
	for qemu-devel@nongnu.org; Wed, 11 Dec 2013 18:56:42 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lig.fnst@cn.fujitsu.com>) id 1Vqtdp-0005zT-2q
	for qemu-devel@nongnu.org; Wed, 11 Dec 2013 18:56:38 -0500
Received: from [222.73.24.84] (port=27345 helo=song.cn.fujitsu.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lig.fnst@cn.fujitsu.com>) id 1Vqtdo-0005z7-O3
	for qemu-devel@nongnu.org; Wed, 11 Dec 2013 18:56:33 -0500
Message-ID: <52A8FB4A.9060606@cn.fujitsu.com>
Date: Thu, 12 Dec 2013 07:54:50 +0800
From: Li Guang <lig.fnst@cn.fujitsu.com>
MIME-Version: 1.0
References: <1386547806-22298-1-git-send-email-lig.fnst@cn.fujitsu.com>	<1386547806-22298-6-git-send-email-lig.fnst@cn.fujitsu.com>	<CAEgOgz5yS2jXeWk6sk9U+WnwyZpsZrubjVqis0w8c0zHorsR_A@mail.gmail.com>	<CAFEAcA8NqycDC1_gfNVMncy2+9pvAmRKNziCW0j8K_NJcocE6g@mail.gmail.com>	<CAEgOgz5xk6kMjWSA+AFafg6Sfxtww=j_CQY7jX5ghB4MVnhVgQ@mail.gmail.com>	<CAFEAcA_5vKrohJP-h6xmN0T8yyQXEXpihRjn=rFBWk_po2sKmw@mail.gmail.com>
	<CAEgOgz7AXJiss=Q_5ZXMtGTUzx94qOOH35Po3CQj6AnYb91JOQ@mail.gmail.com>
In-Reply-To: <CAEgOgz7AXJiss=Q_5ZXMtGTUzx94qOOH35Po3CQj6AnYb91JOQ@mail.gmail.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Subject: Re: [Qemu-devel] [PATCH v10 5/5] hw/arm: add cubieboard support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>, =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>

Peter Crosthwaite wrote:
> On Wed, Dec 11, 2013 at 8:31 PM, Peter Maydell<peter.maydell@linaro.org>  wrote:
>    
>> On 11 December 2013 10:24, Peter Crosthwaite
>> <peter.crosthwaite@xilinx.com>  wrote:
>>      
>>> On Wed, Dec 11, 2013 at 7:56 PM, Peter Maydell<peter.maydell@linaro.org>  wrote:
>>>        
>>>> On 11 December 2013 05:59, Peter Crosthwaite
>>>> <peter.crosthwaite@xilinx.com>  wrote:
>>>>          
>>>>> On Mon, Dec 9, 2013 at 10:10 AM, liguang<lig.fnst@cn.fujitsu.com>  wrote:
>>>>>            
>>>>>> Signed-off-by: liguang<lig.fnst@cn.fujitsu.com>
>>>>>>              
>>>>> Acked-by: Peter Crosthwaite<peter.crosthwaite@xilinx.com>
>>>>>            
>>>> Why Acked-by rather than Reviewed-by ?
>>>>
>>>>          
>>> Not 100% myself on the new QOM styles and standards around boards and
>>> SoC. But it is reviewed by me to the best of my knowledge. If that is
>>> enough, please feel free to promote to Reviewed-by.
>>>        
>> I'd call that Reviewed-by, yes. Acked-by is just "I don't object to this"
>> which is a sufficiently weak statement that it's not often used...
>>
>>      
> Ok,
>
> Liguang, please drop the acks on p4 and p5 and replace by Reviewed-by
> on next spin.
>
> Reviewed-by: Peter Crosthwaite<peter.crosthwaite@xilinx.com>
>    

Ok, thanks!