From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alan Coopersmith Subject: Re: [PATCH] Mark drmServerInfo.debug_print with printf attribute Date: Wed, 11 Dec 2013 20:01:32 -0800 Message-ID: <52A9351C.3090802@oracle.com> References: <1386796627-29167-1-git-send-email-keithp@keithp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1386796627-29167-1-git-send-email-keithp@keithp.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: mesa-dev-bounces@lists.freedesktop.org Errors-To: mesa-dev-bounces@lists.freedesktop.org To: Keith Packard Cc: mesa-dev@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On 12/11/13 01:17 PM, Keith Packard wrote: > I stole the conditional for _X_ATTRIBUTE_PRINTF from xproto and > changed the name to _DRM_ATTRIBUTE_PRINTF to avoid future conflicts. > > Signed-off-by: Keith Packard > --- > xf86drm.h | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/xf86drm.h b/xf86drm.h > index 1e763a3..0bf205f 100644 > --- a/xf86drm.h > +++ b/xf86drm.h > @@ -92,8 +92,15 @@ extern "C" { > typedef unsigned int drmSize, *drmSizePtr; /**< For mapped regions */ > typedef void *drmAddress, **drmAddressPtr; /**< For mapped regions */ > > +/* Added in X11R6.9, so available in any version of modular xproto */ You should drop that line - those comments are used for us to figure out which xproto version to list in the pkg-config requirements when using newer _X_* macros out of Xfuncproto.h, so doesn't make sense here. Also be warned that using a macro name starting with an _ will cause you to get complaints about violating the "reserved for the implementation" rule in the ANSI/ISO C standards from people who consider the implementation to solely be the compiler, not the OS. https://bugs.freedesktop.org/show_bug.cgi?id=70686 for example. -- -Alan Coopersmith- alan.coopersmith@oracle.com Oracle Solaris Engineering - http://blogs.oracle.com/alanc