From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36498) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vqxqo-0006Na-ML for qemu-devel@nongnu.org; Wed, 11 Dec 2013 23:26:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vqxqk-0005Th-Ds for qemu-devel@nongnu.org; Wed, 11 Dec 2013 23:26:14 -0500 Received: from mx1.redhat.com ([209.132.183.28]:58462) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vqxqk-0005Td-4f for qemu-devel@nongnu.org; Wed, 11 Dec 2013 23:26:10 -0500 Message-ID: <52A93ADD.9090204@redhat.com> Date: Wed, 11 Dec 2013 21:26:05 -0700 From: Eric Blake MIME-Version: 1.0 References: <1386740912-1655-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1386740912-1655-6-git-send-email-xiawenc@linux.vnet.ibm.com> In-Reply-To: <1386740912-1655-6-git-send-email-xiawenc@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="OlA3bDpLqhXXMJPaXNUAVhwQGakxqIcUb" Subject: Re: [Qemu-devel] [PATCH V4 5/9] qapi script: use same function to generate enum string List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia , qemu-devel@nongnu.org Cc: kwolf@redhat.com, mdroth@linux.vnet.ibm.com, armbru@redhat.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --OlA3bDpLqhXXMJPaXNUAVhwQGakxqIcUb Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 12/10/2013 10:48 PM, Wenchao Xia wrote: > Prior to this patch, qapi-visit.py used custom code to generate enum > names used for handling a qapi union. Fix it to instead reuse common > code, with identical generated results, and allowing future updates to > generation to only need to touch one place. >=20 > Signed-off-by: Wenchao Xia > --- > scripts/qapi-types.py | 6 +++--- > scripts/qapi-visit.py | 21 +++++++++++++++------ > scripts/qapi.py | 15 +++++++++++---- > 3 files changed, 29 insertions(+), 13 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --OlA3bDpLqhXXMJPaXNUAVhwQGakxqIcUb Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSqTrdAAoJEKeha0olJ0Nqs8YH/j2ECNHo4gErQHWjZzJ/E0Np AqQvV+Iqvypce9lnSSTKNuH97w/Ykk0MH5rP2BnlN7j/hQKpPiPuz/SPNRS9UwJu rAGF3f8AjLL7OgTagBWkG5L2eYMCQdx3MJA9bbW2rOVZXiNNbtPDe3lRO2Iaog8c SCIfg+r5RDYmTQhP2HYMEupkzL6yGCluokZyfNbya2NxccT3VsuSi/57ZxXrK8ge u2+ASYqvXFwY5o0wIieN3P4skHS+1kXsoAbMUli4NUnJhwopa1S2m57OGFajtzyt XY5+ZbCaNG/sp8QZ4e+f6nUMuX/zGK2OZlaGkTEf4TPDtokS6z6pF5eLrMqs3Z8= =Z25X -----END PGP SIGNATURE----- --OlA3bDpLqhXXMJPaXNUAVhwQGakxqIcUb--