From: michael.opdenacker@free-electrons.com (Michael Opdenacker)
To: linux-arm-kernel@lists.infradead.org
Subject: [GIT PULL][for 3.14] pull request from pxa
Date: Thu, 12 Dec 2013 05:51:00 +0100 [thread overview]
Message-ID: <52A940B4.7090807@free-electrons.com> (raw)
In-Reply-To: <52A91B4B.2050907@gmail.com>
On 12/12/2013 03:11 AM, Haojian Zhuang wrote:
> On 12/12/2013 09:29 AM, Olof Johansson wrote:
>>
>>>
>>> Michael Opdenacker (1):
>>> ARM: pxa: remove IRQF_DISABLED
>>
>> This patch doesn't even build:
>>
>> arch/arm/mach-pxa/pcm990-baseboard.c:331:9: error: too few arguments to
>> function 'request_irq'
>>
>> Why the !@%@# are you sending me code for your platform that you didn't
>> even bother building to check for errors?
>>
>> I've fixed it up, but you really have to do better than this.
>>
>>
>> -Olof
>>
>
> I'm sorry on this. I'll be careful in the future.
>
> Best Regards
> Haojian
That's *my* fault. This patch was rather trivial and at that's why I was
confident it didn't need testing. However, I messed up on that
particular line.
My apologies!!! I'll be extra careful next time.
Michael.
--
Michael Opdenacker, CEO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
+33 484 258 098
prev parent reply other threads:[~2013-12-12 4:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-11 8:35 [GIT PULL][for 3.14] pull request from pxa Haojian Zhuang
2013-12-12 0:42 ` Olof Johansson
2013-12-12 2:08 ` Haojian Zhuang
2013-12-12 11:17 ` Thierry Reding
2013-12-12 1:29 ` Olof Johansson
2013-12-12 2:11 ` Haojian Zhuang
2013-12-12 4:51 ` Michael Opdenacker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A940B4.7090807@free-electrons.com \
--to=michael.opdenacker@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.