From: Igor Grinberg <grinberg@compulab.co.il>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v5] arm: omap3: Add SPL support to cm_t35
Date: Thu, 12 Dec 2013 10:27:33 +0200 [thread overview]
Message-ID: <52A97375.6020001@compulab.co.il> (raw)
In-Reply-To: <52A87CF2.2090003@denx.de>
On 12/11/13 16:55, Stefan Roese wrote:
> Hi Igor!
>
> On 11.12.2013 15:35, Igor Grinberg wrote:
>> Finally, I've found some time to look at the patch...
>> Generally, it is fine...
>> I say generally, because we have found several bugs, but they
>> are not related to your patch... but to Pekon's work on the
>> omap nand driver. Nikita is on them ;-)
>
> Good. :)
>
>> One minor comment below...
>
> <snip>
>
>>> +/* Defines for SPL */
>>> +#define CONFIG_SPL
>>> +#define CONFIG_SPL_FRAMEWORK
>>> +#define CONFIG_SPL_NAND_SIMPLE
>>> +
>>> +#define CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR 0x300 /* address 0x60000 */
>>> +#define CONFIG_SYS_U_BOOT_MAX_SIZE_SECTORS 0x200 /* 256 KB */
>>
>> Our U-Boot binary sizes are beyond 300KiB...
>> This config is not used anywhere besides config files and README...
>> That's why it probably works for you...
>> I think we should either remove it from the README and configs, or
>> set it to 0x300 or even 0x400 instead (in case we still want to use it,
>> although I don't know why, as we have the size from the image header).
>
> Good catch. If it is not used/referenced at all, then let's remove it
> completely. It makes no sense to drag such an unused define along. Could
> lead only to confusion.
>
> But we can and should remove this in a separate patch.
Fare enough!
Tom, can you please apply this one?
Thanks!
--
Regards,
Igor.
next prev parent reply other threads:[~2013-12-12 8:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-04 12:54 [U-Boot] [PATCH v5] arm: omap3: Add SPL support to cm_t35 Stefan Roese
2013-12-11 14:35 ` Igor Grinberg
2013-12-11 14:55 ` Stefan Roese
2013-12-12 8:27 ` Igor Grinberg [this message]
2013-12-13 12:46 ` [U-Boot] [U-Boot,v5] " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A97375.6020001@compulab.co.il \
--to=grinberg@compulab.co.il \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.