From: Paolo Bonzini <pbonzini@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Vadim Rozenfeld <vrozenfe@redhat.com>, kvm@vger.kernel.org, pl@dlhnet.de
Subject: Re: [RFC PATCH v3 1/2] add support for Hyper-V reference time counter
Date: Thu, 12 Dec 2013 10:33:15 +0100 [thread overview]
Message-ID: <52A982DB.6010609@redhat.com> (raw)
In-Reply-To: <20131211185904.GB28207@amt.cnet>
Il 11/12/2013 19:59, Marcelo Tosatti ha scritto:
> > Where does the docs say that HV_X64_MSR_HYPERCALL is the where the clock
> > starts counting?
> >
> > No need to store kvmclock_offset in hv_ref_count? (moreover
> > the name is weird, better name would be "hv_ref_start_time".
>
> Just add kvmclock_offset when reading the values (otherwise you have a
> "stale copy" of kvmclock_offset in hv_ref_count).
As mentioned in my review, v4 will probably read kvmclock to provide the
reference time counter. So all the complexity of kvmclock_offset will
be hidden behind a function.
Paolo
next prev parent reply other threads:[~2013-12-12 9:33 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-08 11:33 [RFC PATCH v3 0/2] Hyper-V timers Vadim Rozenfeld
2013-12-08 11:33 ` [RFC PATCH v3 1/2] add support for Hyper-V reference time counter Vadim Rozenfeld
2013-12-09 14:23 ` Paolo Bonzini
2013-12-10 10:46 ` Vadim Rozenfeld
2013-12-11 18:53 ` Marcelo Tosatti
2013-12-11 18:59 ` Marcelo Tosatti
2013-12-12 9:33 ` Paolo Bonzini [this message]
2014-01-02 16:52 ` Peter Lieven
2014-01-07 9:36 ` Vadim Rozenfeld
2014-01-07 17:52 ` Peter Lieven
2014-01-08 9:40 ` Vadim Rozenfeld
2014-01-08 10:15 ` Peter Lieven
2014-01-08 10:44 ` Vadim Rozenfeld
2014-01-08 11:48 ` Peter Lieven
2014-01-08 12:12 ` Vadim Rozenfeld
2014-01-08 14:54 ` Peter Lieven
2014-01-08 20:08 ` Vadim Rozenfeld
2014-01-08 22:20 ` Peter Lieven
2014-01-09 11:10 ` Vadim Rozenfeld
2014-01-12 12:08 ` Vadim Rozenfeld
2014-01-12 20:35 ` Peter Lieven
2014-01-02 13:15 ` Peter Lieven
2014-01-02 13:57 ` Marcelo Tosatti
2014-01-02 16:08 ` Peter Lieven
2014-01-02 20:05 ` Marcelo Tosatti
2014-01-13 12:10 ` Vadim Rozenfeld
2013-12-08 11:33 ` [RFC PATCH v3 2/2] add support for Hyper-V partition reference time enlightenment Vadim Rozenfeld
2013-12-09 14:32 ` Paolo Bonzini
2013-12-10 11:23 ` Vadim Rozenfeld
2013-12-10 16:52 ` Paolo Bonzini
2013-12-11 10:58 ` Vadim Rozenfeld
2013-12-11 12:28 ` Paolo Bonzini
2013-12-11 19:28 ` Marcelo Tosatti
2013-12-11 19:27 ` Marcelo Tosatti
2013-12-12 9:34 ` Paolo Bonzini
2014-01-14 4:11 ` Vadim Rozenfeld
2014-01-14 13:54 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A982DB.6010609@redhat.com \
--to=pbonzini@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=pl@dlhnet.de \
--cc=vrozenfe@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.