From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47072) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vr5lq-00075p-Bg for qemu-devel@nongnu.org; Thu, 12 Dec 2013 07:53:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vr5le-0001JT-6L for qemu-devel@nongnu.org; Thu, 12 Dec 2013 07:53:38 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40195) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vr5ld-0001JJ-Uu for qemu-devel@nongnu.org; Thu, 12 Dec 2013 07:53:26 -0500 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBCCrPm8017100 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 12 Dec 2013 07:53:25 -0500 Message-ID: <52A9B1BA.8060003@redhat.com> Date: Thu, 12 Dec 2013 20:53:14 +0800 From: Fam Zheng MIME-Version: 1.0 References: <1386836626-6436-1-git-send-email-famz@redhat.com> <1386836626-6436-2-git-send-email-famz@redhat.com> <87k3facjzf.fsf@blackfin.pond.sub.org> In-Reply-To: <87k3facjzf.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v7 01/10] qapi: Add BlockOperationType enum List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: kwolf@redhat.com, qemu-devel@nongnu.org, rjones@redhat.com, imain@redhat.com, stefanha@redhat.com, pbonzini@redhat.com On 2013=E5=B9=B412=E6=9C=8812=E6=97=A5 20:49, Markus Armbruster wrote: > Fam Zheng writes: > >> This adds the enum of all the operations that can be taken on a block >> device. > > All operations? All blockable operations? Something else? > All QMP operations those apply on device, plus all operations those=20 "in_use" is protecting, at least. I will reconsider this enum or update=20 the comment. Fam