From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Florent Fourcot <florent.fourcot@enst-bretagne.fr>,
netdev@vger.kernel.org
Subject: Re: [PATCH] ipv6: fix incorrect type in initializer
Date: Thu, 12 Dec 2013 18:36:06 +0400 [thread overview]
Message-ID: <52A9C9D6.7040200@cogentembedded.com> (raw)
In-Reply-To: <1386844881-32017-1-git-send-email-florent.fourcot@enst-bretagne.fr>
Hello.
On 12-12-2013 14:41, Florent Fourcot wrote:
s/initializer/declaration/.
> Introduced by 1397ed35f22d7c30d0b89ba74b6b7829220dfcfd
> "ipv6: add flowinfo for tcp6 pkt_options for all cases"
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Florent Fourcot <florent.fourcot@enst-bretagne.fr>
> ---
> net/ipv6/ipv6_sockglue.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/net/ipv6/ipv6_sockglue.c b/net/ipv6/ipv6_sockglue.c
> index bc4d8a2..dac04d2 100644
> --- a/net/ipv6/ipv6_sockglue.c
> +++ b/net/ipv6/ipv6_sockglue.c
> @@ -1035,7 +1035,7 @@ static int do_ipv6_getsockopt(struct sock *sk, int level, int optname,
> put_cmsg(&msg, SOL_IPV6, IPV6_2292HOPLIMIT, sizeof(hlim), &hlim);
> }
> if (np->rxopt.bits.rxflow) {
> - int flowinfo = np->rcv_flowinfo;
> + __be32 flowinfo = np->rcv_flowinfo;
Empty line wouldn't hurt here, after declaration.
> put_cmsg(&msg, SOL_IPV6, IPV6_FLOWINFO, sizeof(flowinfo), &flowinfo);
WBR, Sergei
prev parent reply other threads:[~2013-12-12 14:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-12 10:41 [PATCH] ipv6: fix incorrect type in initializer Florent Fourcot
2013-12-12 14:36 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A9C9D6.7040200@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=florent.fourcot@enst-bretagne.fr \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.