From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751542Ab3LLPay (ORCPT ); Thu, 12 Dec 2013 10:30:54 -0500 Received: from mail.windriver.com ([147.11.1.11]:52277 "EHLO mail.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751162Ab3LLPax (ORCPT ); Thu, 12 Dec 2013 10:30:53 -0500 Message-ID: <52A9D6A0.8040107@windriver.com> Date: Thu, 12 Dec 2013 10:30:40 -0500 From: Paul Gortmaker User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-Version: 1.0 To: Steven Rostedt CC: Thomas Gleixner , Christoph Hellwig , Peter Zijlstra , Ingo Molnar , Sebastian Andrzej Siewior , "Paul E. McKenney" , Andrew Morton , Subject: Re: [PATCH 1/3] wait-simple: Introduce the simple waitqueue implementation References: <1386810399-8973-1-git-send-email-paul.gortmaker@windriver.com> <1386810399-8973-2-git-send-email-paul.gortmaker@windriver.com> <20131212080314.GA25783@infradead.org> <52A9CCA6.6040806@windriver.com> <20131212095533.1fab411f@gandalf.local.home> In-Reply-To: <20131212095533.1fab411f@gandalf.local.home> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [128.224.146.65] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13-12-12 09:55 AM, Steven Rostedt wrote: > On Thu, 12 Dec 2013 09:48:06 -0500 > Paul Gortmaker wrote: > >> 1) git mv wait.[ch] --- > cwait.[ch] >> make an empty wait.h include cwait.h temporarily >> >> 2) rename all existing functions in cwait.[ch] to have an added >> "c" prefix (or similar) >> >> in wait.h, temporarily add a bunch of things like >> #define wait_xyz cwait_xyz >> so that things still compile and link. > > What about instead change all users of wait_*() to cwait_*(). This might turn out to be a big patch, but it is largely just a mechanical sed, so I guess that is OK. > > Then the next steps would be to skip 3 and jump right to 4) > >> >> 3) track down the users who really need the extra complexity >> and have them use cwait calls and include cwait.h >> >> 4) bring in the simple wait queue support as wait.c and wait.h >> and delete the defines added in step two. This will be the >> flag day commit. > > Not a flag day commit, as no one is using it. Then start converting all > users back to the wait_*() functions one at a time. If something > breaks, we know which one it was. Yep, I think that would work and would avoid the flag day problem that I was dreading. Paul. -- > > -- Steve > >> >> Is that what we want to do here? >>