From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vladimir Davydov Subject: Re: [PATCH] cgroup: fix fail path in cgroup_load_subsys() Date: Thu, 12 Dec 2013 22:51:45 +0400 Message-ID: <52AA05C1.1070709@parallels.com> References: <1386403085-24866-1-git-send-email-vdavydov@parallels.com> <20131212153536.GD32683@htj.dyndns.org> <20131212155523.GF32683@htj.dyndns.org> <52AA026C.3040605@parallels.com> <20131212184506.GK32683@htj.dyndns.org> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20131212184506.GK32683-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Tejun Heo Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devel-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org, Li Zefan On 12/12/2013 10:45 PM, Tejun Heo wrote: > Hello, > > On Thu, Dec 12, 2013 at 10:37:32PM +0400, Vladimir Davydov wrote: >> If so, I don't mind, but why? cgroup_unload_subsys() should never be >> called without properly initialized css. > Hmm.... I think it's generally preferable to reuse normal exit path > for error handling as much as possible. Plus, the normal cgroup init > failure path behaves that way. That said, it's more of a preference > and if you have technical argument, I'd be happy to give in. :) Got it, will do. Thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751940Ab3LLSvx (ORCPT ); Thu, 12 Dec 2013 13:51:53 -0500 Received: from relay.parallels.com ([195.214.232.42]:34221 "EHLO relay.parallels.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751092Ab3LLSvu (ORCPT ); Thu, 12 Dec 2013 13:51:50 -0500 Message-ID: <52AA05C1.1070709@parallels.com> Date: Thu, 12 Dec 2013 22:51:45 +0400 From: Vladimir Davydov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130922 Icedove/17.0.9 MIME-Version: 1.0 To: Tejun Heo CC: , , , Li Zefan Subject: Re: [PATCH] cgroup: fix fail path in cgroup_load_subsys() References: <1386403085-24866-1-git-send-email-vdavydov@parallels.com> <20131212153536.GD32683@htj.dyndns.org> <20131212155523.GF32683@htj.dyndns.org> <52AA026C.3040605@parallels.com> <20131212184506.GK32683@htj.dyndns.org> In-Reply-To: <20131212184506.GK32683@htj.dyndns.org> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.24.25.135] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/12/2013 10:45 PM, Tejun Heo wrote: > Hello, > > On Thu, Dec 12, 2013 at 10:37:32PM +0400, Vladimir Davydov wrote: >> If so, I don't mind, but why? cgroup_unload_subsys() should never be >> called without properly initialized css. > Hmm.... I think it's generally preferable to reuse normal exit path > for error handling as much as possible. Plus, the normal cgroup init > failure path behaves that way. That said, it's more of a preference > and if you have technical argument, I'd be happy to give in. :) Got it, will do. Thanks.